Repository navigation
Add in-game Mod Settings with persistent preferences and shortcut editing - #333
Open
Guffawaffle wants to merge 19 commits into
Open
Guffawaffle wants to merge 19 commits into
Guffawaffle wants to merge 19 commits into
Conversation
This was referenced Oct 18, 2026
Guffawaffle
marked this pull request as ready for review
October 19, 2026 06:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds searchable Mod Settings to the game's Settings menu, with preference editing, shortcut recording, defaults and help. Changes save in the background while preserving unrelated TOML values and comments, with feedback for save failures, conflicts and restart requirements. Advanced and secret-bearing configuration remains in TOML.
Includes titled choice groups, inline sliders with precise Edit controls, a loading-image file picker, independent daily-faction checkboxes, and accurate Kirshara protection availability. The chat-title crash fix from #337 is included.
#338 is independent, but merging it first is recommended before reconciling the overlapping faction parser/example changes. Mac Kirshara platform support is separate in #339.
Validation: local Windows release builds, settings/persistence and focused regression fixtures, and three independent review lanes pass. Windows player smoke covers downstream test artifacts; exact-candidate smoke and current-client Mac hook-fit/runtime qualification remain pending, so this stays a draft.
See docs/MOD_SETTINGS.md for behavior and the smoke checklist.