Repository navigation
Fix camera following selected targets - #340
Closed
DerPizzadieb wants to merge 2 commits into
Closed
DerPizzadieb wants to merge 2 commits into
DerPizzadieb wants to merge 2 commits into
Conversation
The Camera gets detached from your targets, not snapping on them anymore. This creates less stress for the eye by causing less camera movement on the screen. Unfortunately the Target Pointer from the Target Window points into empty space with it.
Collaborator
|
Unfortunately @DerPizzadieb, the way this change has been done, it has merged a lot of other changes in with it. Your fix/disable-target-camera-lock branch is based on main which is the last full release. And then the commit you made also brought in all our dev changes too but in a single commit, so it's impossible to see your actual change and may have been the reason for your issues the other day. I would advise making sure that you are on the dev branch locally and in sync with the github repo. Then create a branch from the latest dev HEAD, maybe called feat/fixed-camera and apply just the changes needed to make your concept work, then push and create the pr from that branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Camera gets detached from your targets, not snapping on them anymore. This creates less stress for the eye by causing less camera movement on the screen. Unfortunately the Target Pointer from the Target Window points into empty space with it.