Repository navigation
Sync: fix the macOS build after #325 (floating-point from_chars) - #352
Open
ProgenyAlpha wants to merge 1 commit into
Open
ProgenyAlpha wants to merge 1 commit into
ProgenyAlpha wants to merge 1 commit into
Conversation
…t from_chars std::from_chars for double is unavailable before macOS 26 (build-mac failed on dev after STFC-Mod#325). The shortest float text from to_chars is now read back through a classic-locale stream.
ProgenyAlpha
force-pushed
the
fix/mac-float-from-chars
branch
from
October 27, 2026 20:27
b28ee40 to
f759a6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mac builds on
devfail since #325 was merged (Windows passes):number(float)read itsto_charstext back with floating-pointstd::from_chars. libc++ provides that only on macOS 26 and newer, and the build targets macOS 14.6. The integerfrom_charsfrom #342 is not affected.The text is still written with
to_chars(shortest form, so14.364stays14.364). It is now read back through anistringstreamset to the classic locale, so the output does not change.Testing: the Windows release build passes. I have no Mac to build or run it on, so whether this fixes the Mac build will only show once CI runs on this PR.