NamedArrayPartition zeromatrix#446
Merged
ChrisRackauckas merged 2 commits intoSciML:arraypart_zerofrom May 12, 2025
Merged
Conversation
A function similar to what is implemented commit 2094a78 but for NamedArrayPartitions rather than ArrayPartitions. Tested privately to work with Implicit solvers in OrdinaryDiffEq.jl
ChrisRackauckas
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New function implemented for ArrayInterface.zeromatrix for a NamedArrayPartition rather than an ArrayPartition in the style of commit 2094a78. Tests also implemented for both the return type and size of the zeromatrix. The implementation has been privately tested to work with OrdinaryDiffEq.jl and the implicit solvers that previously errored.
Additional context
Created as a fix to SciML/OrdinaryDiffEq.jl#2707