portable-virtualbox@6.4.10.5.1.22: fixed download link, checkver and autoupdate#17954
portable-virtualbox@6.4.10.5.1.22: fixed download link, checkver and autoupdate#17954arvdk wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThis pull request updates the Portable-VirtualBox manifest to migrate the primary download endpoint from HTTP to HTTPS and restructures version detection logic. The manifest now uses a PowerShell-based checkver script that extracts both the Portable-VirtualBox and bundled VirtualBox versions from filenames, queries the VirtualBox download index to retrieve build numbers, and auto-generates three HTTPS URL templates for the portable archive, VirtualBox executable, and extension pack. This addresses the non-standard versioning scheme where multiple VirtualBox versions are bundled with a single Portable-VirtualBox release. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/verify |
|
All changes look good. Wait for review from human collaborators. portable-virtualbox
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/portable-virtualbox.json (1)
42-46: Run local manifest validation before merge.Please validate this manifest end-to-end with:
scoop config debug truescoop config gh_token <your-github-token>.\bin\checkver.ps1 -App portable-virtualbox -f.\bin\formatjson.ps1 -App portable-virtualbox- Install test(s):
scoop install bucket/portable-virtualbox.json -a <architecture>Reference docs:
- https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines, “Provide clear instructions for testing the manifest locally before submission” and include official contribution/wiki links.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/portable-virtualbox.json` around lines 42 - 46, The manifest bucket/portable-virtualbox.json contains the "url" array entries that must be validated end-to-end before merge; run the local manifest validation and install tests (enable debug and GH token, run checkver and formatjson, then attempt scoop install) as described in the review: run scoop config debug true and scoop config gh_token <token>, then .\bin\checkver.ps1 -App portable-virtualbox -f, .\bin\formatjson.ps1 -App portable-virtualbox and finally test installation with scoop install bucket/portable-virtualbox.json -a <architecture>; fix any checkver/formatjson/install errors and update the "url" entries or version/build variables ($matchVboxversion, $matchVboxbuild, $matchHead) in portable-virtualbox.json accordingly, and add a note in the PR that you ran these validation steps and linked the Scoop contribution/wiki docs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/portable-virtualbox.json`:
- Around line 42-46: The manifest bucket/portable-virtualbox.json contains the
"url" array entries that must be validated end-to-end before merge; run the
local manifest validation and install tests (enable debug and GH token, run
checkver and formatjson, then attempt scoop install) as described in the review:
run scoop config debug true and scoop config gh_token <token>, then
.\bin\checkver.ps1 -App portable-virtualbox -f, .\bin\formatjson.ps1 -App
portable-virtualbox and finally test installation with scoop install
bucket/portable-virtualbox.json -a <architecture>; fix any
checkver/formatjson/install errors and update the "url" entries or version/build
variables ($matchVboxversion, $matchVboxbuild, $matchHead) in
portable-virtualbox.json accordingly, and add a note in the PR that you ran
these validation steps and linked the Scoop contribution/wiki docs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e7aeff76-6de0-4b2a-a9f3-28a512f9d03e
📒 Files selected for processing (1)
bucket/portable-virtualbox.json
Closes #1677
Fixed the first of 3 download links. The auto update was not implemented for the latter two, so added those. Since not all information was found on one webpage, I converted it to a script. Looks Ok now, although the 6 numbers do make a long version now.
<manifest-name[@version]|chore>: <general summary of the pull request>