Skip to content

portable-virtualbox@6.4.10.5.1.22: fixed download link, checkver and autoupdate#17954

Open
arvdk wants to merge 1 commit into
ScoopInstaller:masterfrom
arvdk:portable-virtualbox-checkver-fix
Open

portable-virtualbox@6.4.10.5.1.22: fixed download link, checkver and autoupdate#17954
arvdk wants to merge 1 commit into
ScoopInstaller:masterfrom
arvdk:portable-virtualbox-checkver-fix

Conversation

@arvdk
Copy link
Copy Markdown

@arvdk arvdk commented Jun 1, 2026

Closes #1677

Fixed the first of 3 download links. The auto update was not implemented for the latter two, so added those. Since not all information was found on one webpage, I converted it to a script. Looks Ok now, although the 6 numbers do make a long version now.

  • [x ] Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • [ x] I have read the Contributing Guide

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This pull request updates the Portable-VirtualBox manifest to migrate the primary download endpoint from HTTP to HTTPS and restructures version detection logic. The manifest now uses a PowerShell-based checkver script that extracts both the Portable-VirtualBox and bundled VirtualBox versions from filenames, queries the VirtualBox download index to retrieve build numbers, and auto-generates three HTTPS URL templates for the portable archive, VirtualBox executable, and extension pack. This addresses the non-standard versioning scheme where multiple VirtualBox versions are bundled with a single Portable-VirtualBox release.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main changes: fixing the download link and implementing checkver and autoupdate for the portable-virtualbox manifest.
Description check ✅ Passed The description includes a reference to the linked issue (#1677), explains the changes made, and confirms compliance with the contributing guide checklist.
Linked Issues check ✅ Passed The PR directly addresses issue #1677 by updating the checkver to use a script that captures the compound versioning scheme (VirtualBox sub-version + package version) and implements autoupdate for all three download links.
Out of Scope Changes check ✅ Passed All changes are focused on fixing the portable-virtualbox manifest to address the non-standard versioning scheme outlined in issue #1677; no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arvdk
Copy link
Copy Markdown
Author

arvdk commented Jun 1, 2026

/verify

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

All changes look good.

Wait for review from human collaborators.

portable-virtualbox

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
bucket/portable-virtualbox.json (1)

42-46: Run local manifest validation before merge.

Please validate this manifest end-to-end with:

  • scoop config debug true
  • scoop config gh_token <your-github-token>
  • .\bin\checkver.ps1 -App portable-virtualbox -f
  • .\bin\formatjson.ps1 -App portable-virtualbox
  • Install test(s): scoop install bucket/portable-virtualbox.json -a <architecture>

Reference docs:

As per coding guidelines, “Provide clear instructions for testing the manifest locally before submission” and include official contribution/wiki links.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/portable-virtualbox.json` around lines 42 - 46, The manifest
bucket/portable-virtualbox.json contains the "url" array entries that must be
validated end-to-end before merge; run the local manifest validation and install
tests (enable debug and GH token, run checkver and formatjson, then attempt
scoop install) as described in the review: run scoop config debug true and scoop
config gh_token <token>, then .\bin\checkver.ps1 -App portable-virtualbox -f,
.\bin\formatjson.ps1 -App portable-virtualbox and finally test installation with
scoop install bucket/portable-virtualbox.json -a <architecture>; fix any
checkver/formatjson/install errors and update the "url" entries or version/build
variables ($matchVboxversion, $matchVboxbuild, $matchHead) in
portable-virtualbox.json accordingly, and add a note in the PR that you ran
these validation steps and linked the Scoop contribution/wiki docs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@bucket/portable-virtualbox.json`:
- Around line 42-46: The manifest bucket/portable-virtualbox.json contains the
"url" array entries that must be validated end-to-end before merge; run the
local manifest validation and install tests (enable debug and GH token, run
checkver and formatjson, then attempt scoop install) as described in the review:
run scoop config debug true and scoop config gh_token <token>, then
.\bin\checkver.ps1 -App portable-virtualbox -f, .\bin\formatjson.ps1 -App
portable-virtualbox and finally test installation with scoop install
bucket/portable-virtualbox.json -a <architecture>; fix any
checkver/formatjson/install errors and update the "url" entries or version/build
variables ($matchVboxversion, $matchVboxbuild, $matchHead) in
portable-virtualbox.json accordingly, and add a note in the PR that you ran
these validation steps and linked the Scoop contribution/wiki docs.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e7aeff76-6de0-4b2a-a9f3-28a512f9d03e

📥 Commits

Reviewing files that changed from the base of the PR and between 080c49b and 32de184.

📒 Files selected for processing (1)
  • bucket/portable-virtualbox.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

portable-virtualbox: version does not reflect non standard versioning scheme of Portable-VirtualBox

1 participant