feat: remove stack_field setting#12
Merged
Merged
Conversation
- Remove stack_field from screenly.yml and screenly_qc.yml - Drop stackField parameter from renderView and renderKanban - Remove stack_field setting read from main.ts - Remove stack_field test case from kanban.test.ts - Update README to remove stack_field references
There was a problem hiding this comment.
Pull request overview
This PR removes the configurable kanban “stack field” setting and simplifies kanban rendering to always stack by the first singleSelect field in the Airtable schema, with corresponding documentation and test updates.
Changes:
- Removed
stack_fieldfrom Screenly manifests and README configuration examples. - Updated
renderView/renderKanbanAPIs to dropstackFieldName/stackFieldparameters and rely on auto-detection. - Removed the unit test that validated behavior for an explicitly configured but missing
stack_field.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/render.ts | Drops stackField param from renderView and updates kanban rendering call. |
| src/main.ts | Stops reading stack_field setting and calls renderView with only viewData. |
| src/kanban.ts | Removes stackFieldName parameter; always selects the first singleSelect field; updates warning message. |
| src/kanban.test.ts | Removes the test case for missing configured stack_field. |
| screenly.yml | Removes stack_field setting from the manifest. |
| screenly_qc.yml | Removes stack_field setting from the QC manifest. |
| README.md | Removes stack_field from configuration documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stack_fieldfromscreenly.ymlandscreenly_qc.ymlstackFieldNameparameter fromrenderKanbanandstackFieldfromrenderView; kanban now always auto-detects the firstsingleSelectfield