Repository navigation
Expand integration test coverage - #92
Merged
Merged
Conversation
sam-obeid
approved these changes
Sep 23, 2026
mrattle
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR expands integration coverage and removes the requirement for shared test services.
The suite adds 49 integration tests and retains all original tests.
The added integration tests are ported from
Shopify/Dalli, after doing an analysis of the cases covered in that repo (Ruby memcached client) and determining the gap in coverage here.src/andCargo.tomlremain unchanged. This PR does not change library behavior or runtime dependency declarations.Details
TESTING.mdcontains the local execution instructions.The reference environment uses these versions:
Checks
The complete suite passed on macOS ARM64 and Linux ARM64.
It contains 168 integration tests and 43 unit tests. The full run had no failed or ignored tests.
Five additional macOS runs passed with 16 test threads.
These commands passed:
./scripts/test-integration.shcargo fmt --checkcargo clippy --all-targets --all-features -- -D warningscargo test --doc --all-featurescargo build --release --all-featurescargo build --release --all-features --examplesbash -n scripts/install-test-tools.sh scripts/test-integration.shThe Linux checks used a local container.
Benchmarks did not run because the library code remains unchanged.
Current limits
This PR preserves the current client behavior. It does not fix these limits: