Skip to content

Add typed JSON output to autocorrect status - #8931

Merged
gonzaloriestra merged 2 commits into
mainfrom
gonzalo/autocorrect-status-json
Oct 20, 2026
Merged

gonzaloriestra merged 2 commits into
mainfrom
gonzalo/autocorrect-status-json

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

config autocorrect status has no typed JSON result, so scripts cannot reliably read the preference.

Related to https://github.com/shop/issues-develop/issues/24282.

WHAT is this pull request doing?

Add --json with a strict {enabled: boolean} result and discoverable schema. Separate the preference query from the shared presenter while preserving terminal messages. Remove the command's migration exception and refresh the manifest and generated documentation.

How to manually test your changes?

  • Run pnpm shopify config autocorrect status --json --no-input and check that the result contains the current enabled value.
  • Run pnpm shopify config autocorrect status --json-schema to inspect the result schema.
  • Run pnpm shopify config autocorrect status to check the terminal message.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact

@github-actions github-actions Bot added shopify.dev preview Area: @shopify/cli @shopify/cli package issues labels Oct 16, 2026
@gonzaloriestra
gonzaloriestra added this pull request to stack #8934 October 16, 2026 14:29
@github-actions github-actions Bot added no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. and removed Area: @shopify/cli @shopify/cli package issues labels Oct 19, 2026
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review October 19, 2026 10:51
@gonzaloriestra
gonzaloriestra requested review from a team as code owners October 19, 2026 10:51
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/autocorrect-status-json branch 2 times, most recently from 25b5120 to 2509576 Compare October 20, 2026 11:59

@karreiro karreiro left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gonzaloriestra!

@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/autocorrect-status-json branch from 2509576 to feb9102 Compare October 20, 2026 13:19
@gonzaloriestra
gonzaloriestra added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit 1af6831 Oct 20, 2026
31 checks passed
@gonzaloriestra
gonzaloriestra deleted the gonzalo/autocorrect-status-json branch October 20, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. shopify.dev preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants