Repository navigation
Add typed JSON output to autocorrect status - #8931
Merged
Merged
Conversation
gonzaloriestra
added this pull request to stack #8934
October 16, 2026 14:29
gonzaloriestra
marked this pull request as ready for review
October 19, 2026 10:51
isaacroldan
approved these changes
Oct 19, 2026
gonzaloriestra
force-pushed
the
gonzalo/autocorrect-status-json
branch
2 times, most recently
from
October 20, 2026 11:59
25b5120 to
2509576
Compare
karreiro
approved these changes
Oct 20, 2026
gonzaloriestra
force-pushed
the
gonzalo/autocorrect-status-json
branch
from
October 20, 2026 13:19
2509576 to
feb9102
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
config autocorrect statushas no typed JSON result, so scripts cannot reliably read the preference.Related to https://github.com/shop/issues-develop/issues/24282.
WHAT is this pull request doing?
Add
--jsonwith a strict{enabled: boolean}result and discoverable schema. Separate the preference query from the shared presenter while preserving terminal messages. Remove the command's migration exception and refresh the manifest and generated documentation.How to manually test your changes?
pnpm shopify config autocorrect status --json --no-inputand check that the result contains the currentenabledvalue.pnpm shopify config autocorrect status --json-schemato inspect the result schema.pnpm shopify config autocorrect statusto check the terminal message.Checklist