Repository navigation
Add typed JSON output to autocorrect off - #8933
Open
gonzaloriestra wants to merge 2 commits into
Open
gonzaloriestra wants to merge 2 commits into
gonzaloriestra wants to merge 2 commits into
Conversation
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/themes/theme-manager.d.ts@@ -11,12 +11,5 @@ export declare abstract class ThemeManager {
findOrCreate(name?: string, role?: Role): Promise<Theme>;
fetch(name?: string, role?: Role): Promise<Theme | undefined>;
generateThemeName(context: string): string;
- create(themeRole?: Role, themeName?: string): Promise<{
- createdAtRuntime: boolean;
- id: number;
- name: string;
- processing: boolean;
- role: string;
- src?: string;
- }>;
+ create(themeRole?: Role, themeName?: string): Promise<Theme>;
}
\ No newline at end of file
|
gonzaloriestra
force-pushed
the
gonzalo/autocorrect-off-json
branch
from
October 19, 2026 09:44
7bd745d to
e614504
Compare
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Built from Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20261019103528Caution After installing, validate the version by running |
gonzaloriestra
marked this pull request as ready for review
October 19, 2026 10:51
isaacroldan
approved these changes
Oct 19, 2026
gonzaloriestra
force-pushed
the
gonzalo/autocorrect-off-json
branch
from
October 19, 2026 11:59
e614504 to
713f0b2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
config autocorrect offcannot return the saved preference as a typed JSON result.Fixes https://github.com/shop/issues-develop/issues/24282.
WHAT is this pull request doing?
Add
--jsonusing the shared autocorrect result schema and presenter. Return{enabled: false}after saving the preference, preserve the terminal message, and refresh the migration exceptions, manifest, and generated documentation. Extend the command contract tests to cover disabling autocorrect.How to manually test your changes?
pnpm shopify config autocorrect status.pnpm shopify config autocorrect off --json --no-inputand check for{"enabled": false}.pnpm shopify config autocorrect status --jsonto confirm the preference was saved, then restore the original setting with the correspondingonoroffcommand.Checklist