Skip to content

[Refactor] Build cookie record declaratively in parseCookies #8954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Refactor] Build cookie record declaratively in parseCookies #8954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions packages/theme/src/cli/utilities/theme-environment/cookies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
export function parseCookies(cookies: string) {
const cookiesRecord: Record<string, string> = {}
export function parseCookies(cookies: string): Record<string, string> {
const entries = cookies.split(';').flatMap((cookie) => {
const [, key, value] = cookie.match(/(.*?)=(.*)$/) ?? []
const trimmedKey = key?.trim()

cookies.split(';').forEach((cookie) => {
const parts = cookie.match(/(.*?)=(.*)$/) ?? []

const key = parts[1]?.trim()
const value = parts[2]?.trim() ?? ''

if (key) {
cookiesRecord[key] = value
}
return trimmedKey ? [[trimmedKey, value?.trim() ?? '']] : []
})

return cookiesRecord
return Object.fromEntries(entries)
}

export function serializeCookies(cookies: Record<string, string>) {
Expand Down