Repository navigation
Upgrade graphql-request to remove url.parse deprecation warnings - #8958
Draft
isaacroldan wants to merge 2 commits into
Draft
isaacroldan wants to merge 2 commits into
isaacroldan wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
GraphQL requests in the bundled CLI can emit Node's
DEP0169warning becausegraphql-request6 usescross-fetchandnode-fetch2, which call the deprecatedurl.parse()API.WHAT is this pull request doing?
Upgrade
graphql-requestto 7.4.0 in CLI Kit and App, so GraphQL uses native fetch. Remove the custom fetch override and cast, and use the new document-analysis API.Preserve Shopify proxy support with an Undici dispatcher for the command's lifetime, including HTTPS fallback and
SHOPIFY_NO_PROXY. Load the proxy implementation only when configured, and restore and close the dispatcher when the command ends. Keep network retries and TLS error classification by reading native fetch error causes, and remove theKeep-Aliveheader that native fetch rejects.Update response fixtures for version 7's types. Add DOM types explicitly to the App package because its WebAssembly APIs previously received them through
cross-fetch.How to manually test your changes?
With Node 26, build and bundle the CLI. From the repository root, run the following with an already linked app directory. This calls the bootstrap directly so Node's warning listener remains active.
Confirm that app versions are listed without a
url.parse()warning. Repeat withSHOPIFY_HTTPS_PROXYset to a working HTTP proxy and confirm the request appears in its logs. SetSHOPIFY_NO_PROXYto the GraphQL host and confirm the request bypasses the proxy.Validation
Checklist