Repository navigation
Inline CLA workflow to remove github-workflows dependency - #522
Merged
Merged
Conversation
lynnsh
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Call
Shopify/shopify-cla-actiondirectly from Hansel's CLA workflow, following the pattern used by EJSON, Krane, and other Shopify repositories.This removes Hansel's dependency on
Shopify/github-workflowsas a small preparatory step toward archiving that repository. It does not archive or otherwise change that repository.Behavior
Inline the job from the currently pinned reusable workflow (
0b6f7f7def1c8f895fd31cd4183f98e3562458e9, v0.2.0), retaining:9938f4b43524d1cfa7471ce9a803edf226697284, v1.8.0), rather than also changing the action version;actions: writeandpull-requests: writepermissions;GITHUB_TOKENandCLA_TOKENsecrets;The check name changes from the nested reusable-job name (
cla / cla) tocla. GitHub's effective branch-rules endpoint returned no required-status-check rule formain; the legacy protection endpoint returned 404. If a required check is configured elsewhere, update its name when landing.Validation
go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7 .github/workflows/cla.ymlgit diff --checkBecause this workflow uses
pull_request_target, the PR's own CLA run executes the base-branch workflow, not this modified version. Live validation of the new workflow requires a subsequent PR/comment event after merge.