Repository navigation
fix: stop include for/with iteration once the partial interrupts - #2143
Open
nagibatorz wants to merge 2 commits into
Open
nagibatorz wants to merge 2 commits into
nagibatorz wants to merge 2 commits into
Conversation
…ing loop Each item rendered by include for/with pushes its own BreakInterrupt/ContinueInterrupt, but the enclosing for loop pops only one, so the leftovers stop the rest of the template. Repro for Shopify#2141.
The partial is rendered for every item without checking for an interrupt in between, so each item pushes another BreakInterrupt or ContinueInterrupt. The enclosing for loop pops only one and the leftovers stop the rest of the template. Stop iterating once the partial raises an interrupt, like for does. Fixes Shopify#2141.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2141. The partial is rendered for every item without checking for an interrupt in between, so each item pushes another BreakInterrupt/ContinueInterrupt. The enclosing for loop pops only one and the leftovers stop the rest of the template. Stop iterating once the partial raises an interrupt. Validation: new test fails on clean main and passes with the fix; full suite 1063 runs, 0 failures.