Repository navigation
fix(vscode): handle ESM Prettier config - #1344
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Fixes #619. The VS Code extension now unwraps ESM Prettier config exports. If config resolution fails, formatting falls back to default options and shows one warning per workspace.
The formatter regression tests, package type-check and build, changed-file ESLint and Prettier checks passed. The package-wide lint still reports existing
no-undeferrors in untouched files.What's next? Any followup issues?
None.
What did you learn?
Prettier can return an ESM config as a module namespace, so the extension needs to unwrap its default export before passing the options to the formatter.
Tophatting
Open a Liquid file in a workspace with an ESM
prettier.config.js, run Format Document and confirm the configured options are applied. With a config that cannot be loaded, confirm formatting uses defaults and shows a warning.Before you deploy
Bug fixes
changeset