Repository navigation
Report a run of trailing pipes as one offense - #1346
Merged
Merged
Conversation
In `{{ 'hello' | upcase | | }}`, LiquidHTMLSyntaxError reported a
repeated-pipe offense and a trailing-pipe offense whose fixes both
rewrote the last `|`. Neither fix alone produced valid Liquid, and
autofix couldn't apply them together: it threw "Overlapping ranges are
not allowed".
Pipes that end the markup are now only a trailing pipe, and its fix
removes all of them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 tasks done
charlespwd
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
In
{{ 'hello' | upcase | | }}, LiquidHTMLSyntaxError reported two offenses whose fixes overlap:|. It throwsOverlapping ranges are not allowed.Pipes that end the markup are now reported only as a trailing pipe, and its fix removes the whole run:
{{ 'hello' | upcase }}. A single trailing pipe is reported exactly as before.What did you learn?
I found this by applying each test's fixes together, as autofix does. This was the only test where they conflicted. The existing test only checked that both offenses had a fix.
Tophatting
{{ 'hello' | | | }},{{ 'hello' | upcase | | | downcase | | }},assign,echo, and pipes inside{% liquid %}. Each gets one fix per problem, and every result is valid Liquid.Before you deploy
changeset🤖 Generated with Claude Code