Repository navigation
Report configs that extend each other - #1351
Merged
Merged
Conversation
2 tasks done
charlespwd
approved these changes
Oct 20, 2026
EvilGenius13
approved these changes
Oct 20, 2026
resolveConfig followed `extends` without remembering where it came from, so two configs that extend each other made it recurse forever, and theme-check hung. It now passes down the configs that extend the current one and throws when the current one is among them. A config extended twice from different places, like a shared base, still resolves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
clauderic
force-pushed
the
cyclic-extends
branch
from
October 20, 2026 13:47
2caa70e to
04110ed
Compare
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1350. Review that one first; this PR's base moves down the stack as the PRs below it merge.
What are you adding in this PR?
Two theme-check configs that extend each other made theme-check hang.
resolveConfigfollowedextendswithout remembering where it came from, so a cycle made it recurse forever.Cyclic extends in theme-check config: a.yml -> b.yml -> a.yml.What's next? Any followup issues?
None.
Tophatting
npx vitest run packages/theme-check-node/src/config/resolve/resolve-config.spec.ts. Without the fix, "rejects configs that extend each other" times out.Before you deploy
changeset🤖 Generated with Claude Code