Repository navigation
fix: match skeleton loader sizes to loaded content - #665
Merged
ritaifeoluwa merged 1 commit intoOct 20, 2026
Merged
Conversation
Skeletons used fixed heights that didn't match the content they stood in for, causing layout shift when data arrived. - TvlChart: use a responsive CSS height shared by the skeleton, empty state and chart instead of useBreakpointValue, whose "sm" fallback rendered the skeleton at 180px before jumping to 140px on phones. - PoolDetailClient: wrap the real stat value and pool title in Skeleton so they size to the text's line box; render the earnings placeholder as the same row of StatCards; render depositor placeholder rows inside the real table instead of taller standalone bars. - Contributors: set skeleton heights to the loaded text line heights. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
❌ Deploy Preview for spiffy-melomakarona-eb1e8a failed.
|
|
@Dove1010 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for smart-drop failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skeletons used fixed heights that didn't match the content they stood in for, causing layout shift when data arrived.
Closes #639
Closes #646
Closes #637
Closes #637
Closes #638
Closes #636