feat: Use a ReadOnlyStore for returning policy data#89
Merged
Conversation
This prevents unnecessarily copying all rules when trying to read data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents unnecessarily copying all rules when trying to read data.
A new Store was created every time data was read, to prevent the in-memory store to be modified outside of the rules storage class, but this results in copying all policies every time data is read which is quite inefficient. This PR resolves this by introducing a new ReadOnlyStore, which retains all functions of an N3 Store that do not modify the Store in place.
Some casts were done in the BaseController to make this work, which are not ideal but that entire class is not ideal in general anyway.