[rend2] Fix dissolve wipes#68
Merged
Merged
Conversation
SomaZ
reviewed
Jun 29, 2026
| default: | ||
| { | ||
| Dissolve.pDissolve = R_FindImageFile( "textures/common/dissolve", type, IMGFLAG_NONE); | ||
| Dissolve.pDissolve = R_FindImageFile( "textures/common/dissolve", type, flags); |
Owner
There was a problem hiding this comment.
IMGFLAG_NONE is correct here, as the texture should not be clamped as per vanilla.
https://github.com/SomaZ/OpenJK/blob/rend2/code/rd-vanilla/tr_draw.cpp#L1002
Author
There was a problem hiding this comment.
Reverted it back to IMGFLAG_NONE.
Owner
There was a problem hiding this comment.
I made the mistake of using flags instead of IMGFLAG_NONE here. Vanilla doesn't use clamp for this texture.
https://github.com/SomaZ/OpenJK/blob/rend2/code/rd-vanilla/tr_draw.cpp#L968
| { | ||
| // read current screen image... (GL_RGBA should work even on 3DFX in that the RGB parts will be valid at least) | ||
| // | ||
| qglReadBuffer (GL_FRONT_LEFT); |
Owner
There was a problem hiding this comment.
I feel like it would be cleaner to just FBO_Bind(NULL); Can you test if that works as well?
Author
There was a problem hiding this comment.
Testing using FBO_Bind(NULL) still occasionally shows a black image.
SomaZ
pushed a commit
that referenced
this pull request
Jun 29, 2026
* [rend2] Fix dissolve wipes * [rend2] No flags for common dissolve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few problems with dissolve wipes: