Skip to content

Commit 1d7e71a

Browse files
committed
Clarify test expectations
1 parent ece9880 commit 1d7e71a

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

lib/src/test/java/org/sonarsource/scanner/lib/internal/JavaRunnerTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ class JavaRunnerTest {
4141
void execute_shouldConsummeProcessStdOut() {
4242
JavaRunner runner = new JavaRunner(Paths.get("java"), JreCacheHit.DISABLED);
4343

44+
// java --version is printing to stdout
4445
assertThat(runner.execute(List.of("--version"), "test", stdOut::add)).isTrue();
4546

4647
assertThat(stdOut).isNotEmpty();
@@ -51,7 +52,7 @@ void execute_shouldConsummeProcessStdOut() {
5152
void execute_shouldLogProcessStdError() {
5253
JavaRunner runner = new JavaRunner(Paths.get("java"), JreCacheHit.DISABLED);
5354

54-
// For some reason the java process exit with 0 even with an unsupported parameter
55+
// java -version is printing to stderr
5556
assertThat(runner.execute(List.of("-version"), null, stdOut::add)).isTrue();
5657

5758
assertThat(stdOut).isEmpty();

0 commit comments

Comments
 (0)