test: rewrite demo-reseed integration tests for the async POST→poll flow

[SoundMindsAI]

Summary

Rewrites the 10 skipped demo-reseed integration tests for the async POST→202→poll contract (they were written against the old synchronous handler; bug_demo_reseed_fake_metric_regression made the flow async + Arq + Redis-poll). Both module-level skip markers removed.

Implements chore_demo_seeding_integration_tests_rewrite.

• Story 0.1 (D-3): Settings.relyloop_worker_api_base_url (default http://api:8000); the worker reads it instead of the hardcoded literal, so the harness redirects self-calls to the in-process uvicorn via a clean env override. No behavior change at the default.
• Epic 1 (harness): module-scoped uvicorn + arq_ctx (real Redis handle for await run_demo_reseed(ctx)) + post_and_run_to_terminal helper; clears the Redis status key + the three Arq demo_reseed:singleton dedup keys before each test and between POSTs (the inline harness never consumes the queued job).
• Epic 2 (11 cases): AC-1/2/3/5/12/13/14/15/16 + AC-Async (monotonic running→complete) + AC-Reg (worker-registration + enqueue guard). The worker runs inline so the advisory lock is pg_locks-observable and the cleanup gate is drivable from the same loop.
• Epic 3 (AC-4): worker-side per-call timeout → terminal failed + cleanup (re-homed from the old 503-on-POST framing).

Test coverage

• Integration: test_demo_seeding.py (11 cases) + test_demo_seeding_timeout.py (1 case); both skip markers removed.
• Unit (test_demo_seeding_status.py) + contract (test_openapi_surface.py, test_test_endpoint_guard.py) unchanged.

Test plan

• ruff format --check + ruff check + mypy backend/ (618 files, clean)
• make test-unit (2656 passed — regression on the unchanged unit file + Story 0.1)
• Both integration files type-check, lint, and import cleanly
• The integration tests run in CI's heavy backend (tests + coverage) lane (Postgres + ES + OS + Redis service containers) — they skip in the sandbox (no local stack), so CI is the authoritative gate for this PR.

Notes / documented deviations

• CI-blind: there is no local Postgres/ES/OS/Redis/uvicorn in the Claude Code remote sandbox, so the rewritten integration tests could not be executed locally; CI is the validation surface (operator-acknowledged).
• Cross-model review: Opus self-review (GPT-5.5 unreachable); Gemini is the live cross-family gate.
• Plan-vs-binding corrections (the worker imports its own bindings, so patching the demo_seeding originals wouldn't intercept worker calls): AC-Async spies backend.workers.demo_reseed.status_set; AC-12 patches the worker's run_demo_reseed_cleanup binding and the demo_seeding cleanup gate. Documented in code comments.

🤖 Generated with Claude Code

---

Generated by Claude Code

[gemini-code-assist]

Code Review

This pull request updates the demo-reseed integration tests to support the new asynchronous flow driven by Arq and Redis polling, replacing the previous synchronous tests. It introduces a new configuration setting, relyloop_worker_api_base_url, allowing the worker to route API self-calls correctly during tests, and documents this in the local development runbook. The review feedback correctly identifies a critical issue in the test files where httpx.ConnectError is raised without the required request keyword-only argument, which would lead to a TypeError at runtime.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

In httpx, ConnectError (which inherits from RequestError) requires a request keyword-only argument. Raising it without a request object will result in a TypeError at runtime: TypeError: RequestError.__init__() missing 1 required keyword-only argument: 'request'.

Since the integration tests were not run locally due to sandbox limitations, this would fail in CI. You can resolve this by passing a dummy httpx.Request object constructed with the intercepted url.

Suggested change

	if call_count["engine_put"] > fail_threshold:
	raise httpx.ConnectError("simulated ES unreachable")
	if call_count["engine_put"] > fail_threshold:
	raise httpx.ConnectError("simulated ES unreachable", request=httpx.Request("PUT", url))

[gemini-code-assist]

In httpx, ConnectError (which inherits from RequestError) requires a request keyword-only argument. Raising it without a request object will result in a TypeError at runtime: TypeError: RequestError.__init__() missing 1 required keyword-only argument: 'request'.

Since the integration tests were not run locally due to sandbox limitations, this would fail in CI. You can resolve this by passing a dummy httpx.Request object constructed with the intercepted url.

Suggested change

	if call_count["engine_put"] > fail_threshold:
	raise httpx.ConnectError("simulated ES unreachable", request=None)
	raise httpx.ConnectError("simulated ES unreachable")
	if call_count["engine_put"] > fail_threshold:
	raise httpx.ConnectError("simulated ES unreachable", request=httpx.Request("PUT", url))