chore: strict-server codegen, CI improvements, remove auto-assign#10
Conversation
|
Claude encountered an error —— View job PR Review
No blocking issues. This is a clean, incremental setup for strict-server codegen. Checked:
🟡 Nits (2)1.
2. - name: Regenerate and check for drift
run: |
make gen
git diff --exit-code internal/gen/
Summary: Both findings are minor. State is success. |
- Enable strict-server mode in oapi-codegen.yaml (typed request/response objects, no manual json.Decoder/Encoder in handlers) - Remove internal/gen/ from .gitignore and .dockerignore so the generated file is tracked and the Docker build context is self-contained - Add .claudeignore to skip indexing internal/gen/ and go.sum (save context tokens) - Add codegen-check CI job with go mod download pre-warm to detect spec/generated-code drift on every PR - Bump setup-go to v6.4.0 across all CI jobs - Remove auto-assign workflow (noise on every PR edit, not needed for small team) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
73d51fc to
3e59b8d
Compare
|
Claude encountered an error —— View job PR Review
No blocking issues. This is a clean, well-structured codegen setup. Checked:
Notes on previous review findings: The previous review flagged The previous review's cold-cache concern for Summary: No findings. State is success. |
Summary
strict-servermode — handlers receive typed request objects and return typed response objects, no manualjson.Decoder/json.Encoderinternal/gen/api.gen.goin git and remove it from.dockerignoreso the repo is self-contained and Docker builds work without a codegen step.claudeignoreto skip indexing large generated files andgo.sum(saves context tokens)codegen-checkCI job that regenerates the spec and fails ifinternal/gen/driftssetup-goto v6.4.0 (SHA-pinned) across all CI jobs — supersedes Dependabot PR chore(deps): bump actions/setup-go from 5.5.0 to 6.4.0 #8auto-assignworkflow — fired on every PR edit including title changes, not useful for a small teamTest plan
🤖 Generated with Claude Code