Skip to content

Fix "year must be in 1..9999, not 0" error during update check #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshdeepsinghin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix "year must be in 1..9999, not 0" error during update check #820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8281167
Fix 'year must be in 1..9999, not 0' during update check
harshdeepsinghin Oct 17, 2026
f3fccb7
Simplify automaticUpdateCheck: use QDateTime comparison directly
harshdeepsinghin Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions syncplay/ui/gui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2123,10 +2123,14 @@ def automaticUpdateCheck(self):
return
try:
if self.config['lastCheckedForUpdates']:
configLastChecked = datetime.strptime(self.config["lastCheckedForUpdates"], "%Y-%m-%d %H:%M:%S.%f")
if self.lastCheckedForUpdates is None or configLastChecked > self.lastCheckedForUpdates.toPython():
self.lastCheckedForUpdates = QDateTime.fromString(self.config["lastCheckedForUpdates"], 'yyyy-MM-dd HH-mm-ss')
if self.lastCheckedForUpdates is None:
lastCheckedFromConfig = QDateTime.fromString(self.config["lastCheckedForUpdates"], 'yyyy-MM-d HH:mm:ss.z')
if lastCheckedFromConfig.isValid() and (
self.lastCheckedForUpdates is None
or not self.lastCheckedForUpdates.isValid()
or lastCheckedFromConfig > self.lastCheckedForUpdates
):
self.lastCheckedForUpdates = lastCheckedFromConfig
if self.lastCheckedForUpdates is None or not self.lastCheckedForUpdates.isValid():
self.checkForUpdates()
else:
timeDelta = currentDateTimeValue.toPython() - self.lastCheckedForUpdates.toPython()
Expand Down