Repository navigation
Conversation
The console chat input only relied on key bindings, which deliver single US-ASCII-representable keys and therefore can never receive text composed by a system input method. Bind the 'any_unicode' text input event to feed composed UTF-8 strings into the input line, and toggle mpv's 'input-ime' property while the input box is open so an IME can compose Chinese/Japanese/Korean text. Both 'any_unicode' and 'input-ime' are available since mpv 0.40.0; on older builds the existing per-key bindings are used unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mpv chat input now accepts text composed by a system input method, so Chinese/Japanese/Korean can be typed with an IME while the input box is open. Requires mpv 0.40+; older versions keep the previous behaviour.