fix(connection-form): move host selection to adjacent row after delete#1294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1293 — MongoDB multi-host editor: after deleting a host row, the remaining rows could not be selected until the form lost and regained focus.
HostListFieldRow.removeSelected()clearedselectedIdto an emptySetimmediately after mutatingentries. SwiftUI'sList(selection:)does not recover its internal selection state cleanly when both the items array and the selection binding flip in the same update, so subsequent clicks on the remaining rows fell through.Fix
Mirror
NSTableViewHIG: when a row is removed, move selection to the row that takes its place (or the new last row if the deleted row was last). The newHostListSelection.nextSelection(afterRemoving:from:)helper does the arithmetic;removeSelected()calls it before mutatingentries.Behavior matrix:
[a, b, c]{b}c[a, b, c]{c}b[a, b]{a}b[a, b, c]{b, c}a[a]{a}Tests
HostListSelectionTestscovers all five matrix rows plus stale-selection (removedIdscontains a UUID that no longer exists) and no-op cases.Test plan
xcodebuild test -only-testing:TableProTests/HostListSelectionTestsgreen−, then click row 2 — row 2 highlights immediately, no focus shuffle needed