feat(datagrid): add default row sort setting (#1284)#1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PluginDefaultSortProvider(no PluginKit ABI bump, uses runtime cast likePluginDiagnosticProvider). Plugins can return.suppressor.forceColumns([String])to override the app setting.SortState.source(.uservs.defaultSort). Default-applied sort does not count as "active work", so preview tabs and Cmd+Click reuse still work.Implementation notes
DefaultSortResolveris a pureenumwith onestatic func, fully covered by unit tests inTableProTests/Services/DefaultSortResolverTests.swift.applyPhase1Resultresolves the default sort once PK is available and triggers a single re-run. Mirrors the existingrestoreFiltersForTablepattern. Gated byTabExecutionState.didEvaluateDefaultSortso it only fires once per tab lifetime.SortStateconstructed by user code naturally getssource: .userfrom the default initializer. No sprinkled flag resets at write sites.Test plan