chore(QTDI-2893): use pattern matching for instanceof (S6201) by undx · Pull Request #1227 · Talend/component-runtime

undx · 2026-05-21T15:58:10Z

https://qlik-dev.atlassian.net/browse/QTDI-2893

Replace instanceof + manual cast patterns with Java 17 pattern matching for instanceof to reduce Sonar warnings (java:S6201).

Both (X) value and X.class.cast(value) cast forms are handled.

Excluded cases:

Conditions combined with || (pattern matching incompatible with alternation): AvroSchemaCache, SchemaConverter (Double||Float).
ParameterSetter#set: target variable declared outside the if block (would require restructuring).
Casts to a type different from the instanceof check (not S6201).

Requirements

Any code change adding any logic MUST be tested through a unit test executed with the default build
Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

What does this PR adds (design/code thoughts)?

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

this PR has been written with the help of GitHub Copilot or another generative AI tool

Replace `instanceof` + manual cast patterns with Java 17 pattern matching for instanceof to reduce Sonar warnings (java:S6201). Both `(X) value` and `X.class.cast(value)` cast forms are handled. Excluded cases: - Conditions combined with `||` (pattern matching incompatible with alternation): AvroSchemaCache, SchemaConverter (Double||Float). - ParameterSetter#set: target variable declared outside the `if` block (would require restructuring). - Casts to a type different from the `instanceof` check (not S6201).

Copilot

Pull request overview

This PR modernizes several Java 17 code paths by replacing instanceof + explicit cast patterns with pattern matching for instanceof, primarily to address Sonar warning java:S6201 across the component runtime and related modules.

Changes:

Refactors multiple instanceof blocks to use Java 17 pattern variables (e.g., if (x instanceof Foo foo)).
Simplifies downstream usage by removing redundant Class#cast() and explicit casts once a pattern variable is available.
Applies the refactor consistently across runtime, DI studio, Beam integration, tools, and tests.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
component-tools/src/main/java/org/talend/sdk/component/tools/validator/ActionValidator.java	Uses pattern matching for `ParameterizedType` handling in return-type validation.
component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/studio/RuntimeContextInjector.java	Refactors `Delegated` handling to use a pattern variable.
component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/studio/ParameterSetter.java	Refactors list access guarded by `instanceof List` to use a pattern variable.
component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/studio/AfterVariableExtracter.java	Refactors `Delegated` handling to use a pattern variable.
component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchema.java	Refactors several `instanceof`/cast sites in schema discovery and result interpretation.
component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/OutputsHandler.java	Refactors `Record` handling to use a pattern variable.
component-runtime-testing/component-runtime-http-junit/src/main/java/org/talend/sdk/component/junit/http/internal/impl/DefaultResponseLocator.java	Refactors `ParameterizedType` equality path to use a pattern variable.
component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/ProducerFinderImplTest.java	Refactors a test helper `Record` cast to pattern matching.
component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/xbean/converter/SchemaConverter.java	Refactors primitive-wrapper handling in JSON conversion (and exposes a Float-cast bug in the touched hunk).
component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/ServiceHelper.java	Refactors `BaseService` cast to pattern matching.
component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java	Refactors `JsonObject` / `JsonArray` casts in `jsonToMap` to pattern matching.
component-runtime-impl/src/main/java/org/talend/sdk/component/runtime/record/RecordImpl.java	Refactors datetime-related `instanceof` casts to pattern matching.
component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/AvroSchemaCache.java	Refactors `SchemaImpl` cast to pattern matching.
component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/AvroRecord.java	Refactors multiple mapping/casting branches to pattern matching.
component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/AvroEntryBuilder.java	Refactors `AvroSchema` cast to pattern matching.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ozhelezniak-talend

LGTM
potentially might have a merge conflict with my pr...

undx · 2026-05-22T08:50:23Z

LGTM potentially might have a merge conflict with my pr...

Sure, you'll merge first, will rebase then.

# Conflicts: # component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/AvroRecord.java # component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/OutputsHandler.java # component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchema.java # component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/studio/ParameterSetter.java

Copilot

Pull request overview

Copilot reviewed 97 out of 98 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

vault-client/src/main/java/org/talend/sdk/components/vault/client/VaultClient.java:415

In the auth error handler, wae.getResponse() is dereferenced even though you already captured it in response. If getResponse() is null, this will throw a NPE while handling an error. Please use the local response variable and guard for null before reading the entity/status.

undx · 2026-06-03T17:26:26Z

LGTM potentially might have a merge conflict with my pr...

Sure, you'll merge first, will rebase then.

rebase brought 83 files more than initial pr.

ozhelezniak-talend · 2026-06-04T07:28:34Z

                final ResponseLocator responseLocator = server.getResponseLocator();
-                if (responseLocator instanceof DefaultResponseLocator) {
+                if (responseLocator instanceof DefaultResponseLocator defaultResponseLocatorVal) {
                    final DefaultResponseLocator defaultResponseLocator =


Strange that IDEA somewhere did a smart replacement and get rid of this variable, and somewhere it's done a dummy replacement with redundant variable.
Did you use Intellij Idea Code clean-up tool?

ozhelezniak-talend · 2026-06-04T07:29:21Z

        executeOnListeners(l -> l.onError(event), null);
-        if (!response.isCommitted() && response instanceof HttpServletResponse) {
-            final HttpServletResponse http = (HttpServletResponse) response;
+        if (!response.isCommitted() && response instanceof HttpServletResponse) { // NOSONAR


again. this NOSONAR is strange...

ozhelezniak-talend · 2026-06-04T07:30:28Z

        onClose.run();
        if (asciidoctor != null && !Boolean.getBoolean("talend.component.tools.jruby.teardown.skip")) {
-            if (asciidoctor instanceof AutoCloseable) {
+            if (asciidoctor instanceof AutoCloseable) { // NOSONAR


Could we double check all those no SONAR (I didn't report all of them in the comments)

Copilot

Pull request overview

Copilot reviewed 102 out of 103 changed files in this pull request and generated 2 comments.

sonar-rnd · 2026-06-04T12:10:08Z

Quality Gate failed

0.00% Coverage on New Code (is less than 80.00%)
117 New Issues (is greater than 0)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

undx added 2 commits May 21, 2026 17:56

chore(QTDI-2893): rename pattern match

e6240c6

undx requested a review from Copilot May 21, 2026 16:45

Copilot started reviewing on behalf of undx May 21, 2026 16:46 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

Comment thread .../src/main/java/org/talend/sdk/component/runtime/manager/xbean/converter/SchemaConverter.java

undx requested a review from ozhelezniak-talend May 21, 2026 17:32

ozhelezniak-talend previously approved these changes May 22, 2026

View reviewed changes

undx added the refactoring label May 29, 2026

undx added 2 commits May 29, 2026 11:38

Merge branch 'master' into ouf/QTDI-2893_pattern_instanceof

7808e1e

undx dismissed ozhelezniak-talend’s stale review via 7a98da0 June 2, 2026 14:30

ozhelezniak-talend previously approved these changes Jun 2, 2026

View reviewed changes

ozhelezniak-talend and others added 2 commits June 3, 2026 16:54

Merge branch 'master' into ouf/QTDI-2893_pattern_instanceof

ff76b94

chore(QTDI-2893): S6201 changes after rebase

4a4ba72

undx dismissed ozhelezniak-talend’s stale review via 4a4ba72 June 3, 2026 17:14

undx requested a review from Copilot June 3, 2026 17:15

Copilot started reviewing on behalf of undx June 3, 2026 17:15 View session

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Comment thread vault-client/src/main/java/org/talend/sdk/components/vault/client/VaultClient.java

Comment thread ...t-tools-webapp/src/main/java/org/talend/sdk/component/tools/webapp/WebAppComponentProxy.java

undx requested a review from ozhelezniak-talend June 3, 2026 17:41

ozhelezniak-talend reviewed Jun 4, 2026

View reviewed changes

Comment thread component-runtime-impl/pom.xml Outdated

ozhelezniak-talend reviewed Jun 4, 2026

View reviewed changes

Comment thread .../org/talend/sdk/component/runtime/manager/reflect/parameterenricher/UiParameterEnricher.java Outdated

ozhelezniak-talend reviewed Jun 4, 2026

View reviewed changes

undx added 4 commits June 4, 2026 11:30

chore(QTDI-2893): S6201 changes after code review

dee61f0

chore(QTDI-2893): reset to master

32956b8

chore(QTDI-2893): S6201 intellij processed

e051e5e

chore(QTDI-2893): S6201 manual processed

9ef6614

undx requested a review from Copilot June 4, 2026 11:46

Copilot started reviewing on behalf of undx June 4, 2026 11:46 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread component-tools/src/main/java/org/talend/sdk/component/tools/AsciidoctorExecutor.java

Comment thread ...nent-server/src/main/java/org/talend/sdk/component/server/front/memory/AsyncContextImpl.java

Conversation

undx commented May 21, 2026

Requirements

Why this PR is needed?

What does this PR adds (design/code thoughts)?

AI generated code

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

ozhelezniak-talend left a comment

Choose a reason for hiding this comment

Uh oh!

undx commented May 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

undx commented Jun 3, 2026

Uh oh!

Uh oh!

Uh oh!

ozhelezniak-talend Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

ozhelezniak-talend Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

ozhelezniak-talend Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

sonar-rnd Bot commented Jun 4, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants