Skip to content

docs(angular/guides/testing): use 'provideHttpClientTesting' instead of the deprecated 'HttpClientTestingModule' and add 'initialPageParam' to the infinite query example - #12181

Merged
sukvvon merged 2 commits into
mainfrom
docs/angular-testing-guide-snippets
Oct 20, 2026

Conversation

@sukvvon

@sukvvon sukvvon commented Oct 20, 2026

Copy link
Copy Markdown
Member

🎯 Changes

  • The HttpClient section registered the deprecated HttpClientTestingModule. Provide provideHttpClient() and provideHttpClientTesting() instead, and update the text and the checklist item to match.
  • The infinite query example defaulted pageParam in the queryFn signature, which v5 replaced with the required initialPageParam. Add initialPageParam: 1 and read pageParam directly.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

…of the deprecated 'HttpClientTestingModule' and add 'initialPageParam' to the infinite query example
@sukvvon sukvvon self-assigned this Oct 20, 2026
@changeset-bot

changeset-bot Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 220298d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud

nx-cloud Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 8f396fd

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ⛔ Cancelled 28s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 36s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-20 03:01:23 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@sukvvon
sukvvon merged commit c223661 into main Oct 20, 2026
3 checks passed
@sukvvon
sukvvon deleted the docs/angular-testing-guide-snippets branch October 20, 2026 03:01
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.76 KB (0%)
react minimal 8.59 KB (0%)

@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: TanStack/query/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4cb3f685-d8fd-4e2c-aec1-aa5c41400cbf
📥 Commits

Reviewing files that changed from the base of the PR and between 55fa959 and 8f396fd.

📒 Files selected for processing: 1
  • docs/framework/angular/guides/testing.md
+------------------------------------------------------------+
| To iterate is human, to recurse divine. - L. Peter Deutsch |
+------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant