Repository navigation
docs(angular/overview): guard the error with 'isError()', rename the 'Response' interface to 'Repo', and remove the unused 'CommonModule' import - #12183
Conversation
…'Response' interface to 'Repo', and remove the unused 'CommonModule' import
|
|
View your CI Pipeline Execution ↗ for commit 2cc6a83
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
size-limit report 📦
|
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎯 Changes
Align the Angular overview example with the
simpleexample it links to:isError()instead oferror(). Readingerror().messageinside@if (error())does not narrow the second call, so the template failed to compile withstrictTemplates(TS2531: Object is possibly 'null').Responseinterface toRepo, so it does not shadow the globalResponsetype.CommonModuleimport.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact