Skip to content

docs(angular/overview): guard the error with 'isError()', rename the 'Response' interface to 'Repo', and remove the unused 'CommonModule' import - #12183

Merged
sukvvon merged 1 commit into
mainfrom
docs/angular-overview-example
Oct 20, 2026
Merged

sukvvon merged 1 commit into
mainfrom
docs/angular-overview-example

Conversation

@sukvvon

@sukvvon sukvvon commented Oct 20, 2026

Copy link
Copy Markdown
Member

🎯 Changes

Align the Angular overview example with the simple example it links to:

  • Guard the error branch with isError() instead of error(). Reading error().message inside @if (error()) does not narrow the second call, so the template failed to compile with strictTemplates (TS2531: Object is possibly 'null').
  • Rename the local Response interface to Repo, so it does not shadow the global Response type.
  • Remove the unused CommonModule import.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

…'Response' interface to 'Repo', and remove the unused 'CommonModule' import
@sukvvon sukvvon self-assigned this Oct 20, 2026
@changeset-bot

changeset-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2cc6a83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud

nx-cloud Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 2cc6a83

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 36s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-20 03:05:51 UTC

@sukvvon
sukvvon merged commit 4ea78d6 into main Oct 20, 2026
7 of 8 checks passed
@sukvvon
sukvvon deleted the docs/angular-overview-example branch October 20, 2026 03:04
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.76 KB (0%)
react minimal 8.59 KB (0%)

@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: TanStack/query/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7513b799-ab02-4140-bc62-b41c5f58d76b
📥 Commits

Reviewing files that changed from the base of the PR and between c223661 and 2cc6a83.

📒 Files selected for processing: 1
  • docs/framework/angular/overview.md
+-----------------------------------------------------------------+
| This is Sparta! And I'm here to kick bugs into the pit of doom. |
+-----------------------------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant