chore(examples/lit/{basic,pagination,ssr}/package.json): remove the unused '@tanstack/query-core' dependency by sukvvon · Pull Request #12188 · TanStack/query

sukvvon · 2026-10-20T03:22:29Z

🎯 Changes

The lit basic, pagination, and ssr examples declared @tanstack/query-core but never import it; it already comes in through @tanstack/lit-query. Remove it from their package.json files and update the lockfile.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Removed the direct @tanstack/query-core dependency from the Lit basic, pagination, and SSR examples.

…nused '@tanstack/query-core' dependency

changeset-bot · 2026-10-20T03:22:36Z

⚠️ No Changeset found

Latest commit: 7db46c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-20T03:22:53Z

View your CI Pipeline Execution ↗ for commit 7db46c4

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 56s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-20 11:58:30 UTC

github-actions · 2026-10-20T03:23:19Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-10-20T03:24:38Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12188

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12188

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12188

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12188

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12188

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12188

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12188

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12188

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12188

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12188

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12188

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12188

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12188

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12188

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12188

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12188

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12188

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12188

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12188

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12188

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12188

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12188

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12188

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12188

commit: 7db46c4

coderabbitai · 2026-10-20T03:24:50Z

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 4604b183-12df-41e5-a228-d27c884a7e22

📥 Commits

Reviewing files that changed from the base of the PR and between 81e6a93 and 24b0a9d.

⛔ Files ignored due to path filters: 1

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing: 3

examples/lit/basic/package.json
examples/lit/pagination/package.json
examples/lit/ssr/package.json

💤 Files with no reviewable changes: 3

examples/lit/ssr/package.json
examples/lit/basic/package.json
examples/lit/pagination/package.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

📝 Walkthrough

The Lit basic, pagination, and SSR examples each remove the direct @tanstack/query-core dependency from their package manifest.

Changes: Lit example dependency cleanup

Layer / File(s)	Summary
Lit example manifest updates `examples/lit/basic/package.json`, `examples/lit/pagination/package.json`, `examples/lit/ssr/package.json`	Each manifest removes `@tanstack/query-core` as a direct dependency.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 24b0a

This change removes an unused dependency from three example projects. It does not affect library code, and no merge-blocking risk was found.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly and concisely identifies the removal of the unused dependency from the three Lit examples.
Description check		The description includes all required sections, explains the change and motivation, completes the checklist, and identifies the change as dev-only with no changeset required.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-20T03:25:05Z

size-limit report 📦

Path	Size
react full	11.76 KB (0%)
react minimal	8.59 KB (0%)

chore(examples/lit/{basic,pagination,ssr}/package.json): remove the u…

24b0a9d

…nused '@tanstack/query-core' dependency

sukvvon self-assigned this Oct 20, 2026

sukvvon marked this pull request as draft October 20, 2026 05:11

Merge branch 'main' into chore/lit-examples-unused-query-core

7db46c4

Navigation Menu

Repository navigation

chore(examples/lit/{basic,pagination,ssr}/package.json): remove the unused '@tanstack/query-core' dependency - #12188

chore(examples/lit/{basic,pagination,ssr}/package.json): remove the unused '@tanstack/query-core' dependency#12188
sukvvon wants to merge 2 commits into
mainfrom
chore/lit-examples-unused-query-core

sukvvon commented Oct 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

nx-cloud Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

pkg-pr-new Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading

Draft PR not reviewed

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Draft PR not reviewed

Uh oh!

github-actions Bot commented Oct 20, 2026

size-limit report 📦

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 20, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Oct 20, 2026 •

edited

Loading

nx-cloud Bot commented Oct 20, 2026 •

edited

Loading

pkg-pr-new Bot commented Oct 20, 2026 •

edited

Loading

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading