fix(lit-query/package.json): remove '@tanstack/query-core' from 'peerDependencies' and move 'lit' to 'devDependencies' by sukvvon · Pull Request #12189 · TanStack/query

sukvvon · 2026-10-20T03:30:26Z

🎯 Changes

Remove @tanstack/query-core from peerDependencies of @tanstack/lit-query. It is already listed in dependencies, so it is always installed with the package.
Move lit from dependencies to devDependencies, so it is declared only in peerDependencies. With lit ^3.3.3 in dependencies, apps on lit 2.8 to 3.3.2 got a second copy of lit installed under @tanstack/lit-query.
Add a patch changeset for @tanstack/lit-query.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Updated package dependency declarations.
- Removed @tanstack/query-core from the package’s peer dependency requirements.
- Moved lit from runtime dependencies to development dependencies.
- No changes were made to exported APIs or application functionality.

…Dependencies' since it is already a dependency

changeset-bot · 2026-10-20T03:30:31Z

🦋 Changeset detected

Latest commit: a1ee041

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@tanstack/lit-query	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nx-cloud · 2026-10-20T03:30:46Z

View your CI Pipeline Execution ↗ for commit a1ee041

Command	Status	Duration	Result
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 2s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-20 11:56:49 UTC

github-actions · 2026-10-20T03:31:14Z

🚀 Changeset Version Preview

1 package(s) bumped directly, 0 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/lit-query`	0.2.30 → 0.2.31	Changeset

pkg-pr-new · 2026-10-20T03:32:26Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12189

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12189

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12189

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12189

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12189

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12189

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12189

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12189

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12189

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12189

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12189

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12189

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12189

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12189

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12189

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12189

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12189

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12189

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12189

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12189

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12189

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12189

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12189

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12189

commit: a1ee041

github-actions · 2026-10-20T03:32:35Z

size-limit report 📦

Path	Size
react full	11.76 KB (0%)
react minimal	8.59 KB (0%)

coderabbitai · 2026-10-20T03:32:51Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⛔ Files ignored due to path filters: 1

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 6d2b5898-0b47-49e4-9c4b-f3638c6aeab1

📥 Commits

Reviewing files that changed from the base of the PR and between 24a4b91 and a1ee041.

⛔ Files ignored due to path filters: 1

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 40937dfc-3a70-4077-a75c-4f7f4e906197

📥 Commits

Reviewing files that changed from the base of the PR and between af7588a and 24a4b91.

⛔ Files ignored due to path filters: 1

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing: 2

.changeset/lit-query-core-peer.md
packages/lit-query/package.json

🚧 Files skipped from review as they are similar to previous changes: 1

.changeset/lit-query-core-peer.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The @tanstack/lit-query package manifest moves lit from runtime dependencies to development dependencies. A patch changeset records the dependency metadata update. The manifest retains @tanstack/query-core as a runtime dependency.

Changes: Lit Query dependency metadata

Layer / File(s)	Summary
Update package dependency metadata `packages/lit-query/package.json`, `.changeset/lit-query-core-peer.md`	The package manifest moves `lit` to development dependencies and keeps `@tanstack/query-core` as a runtime dependency. The patch changeset records dependency metadata changes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 24a4b

The manifest retains the required runtime dependency declarations, and the changeset documents the metadata update. No merge-blocking risk was identified.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly summarizes both primary package metadata changes: removing `@tanstack/query-core` from peerDependencies and moving lit to devDependencies.
Description check		The description includes the required Changes, Checklist, and Release Impact sections. It explains the motivation, confirms testing and policy compliance, and documents the changeset.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…query-core-peer # Conflicts: # docs/framework/lit/installation.md

…ange

…pendencies' so it is declared only as a peer dependency

fix(lit-query/package.json): remove '@tanstack/query-core' from 'peer…

1b53bd1

…Dependencies' since it is already a dependency

sukvvon self-assigned this Oct 20, 2026

sukvvon requested a review from chughgaurav October 20, 2026 03:31

sukvvon added 3 commits October 20, 2026 19:59

Merge remote-tracking branch 'origin/main' into fix/lit-query-remove-…

18900b7

…query-core-peer # Conflicts: # docs/framework/lit/installation.md

docs(lit): restore the install commands to move them to a separate ch…

af7588a

…ange

fix(lit-query/package.json): move 'lit' from 'dependencies' to 'devDe…

24a4b91

…pendencies' so it is declared only as a peer dependency

sukvvon changed the title ~~fix(lit-query/package.json): remove '@tanstack/query-core' from 'peerDependencies' since it is already a dependency~~ fix(lit-query/package.json): remove '@tanstack/query-core' from 'peerDependencies' and move 'lit' to 'devDependencies' Oct 20, 2026

Merge branch 'main' into fix/lit-query-remove-query-core-peer

a1ee041

Navigation Menu

Repository navigation

fix(lit-query/package.json): remove '@tanstack/query-core' from 'peerDependencies' and move 'lit' to 'devDependencies' - #12189

fix(lit-query/package.json): remove '@tanstack/query-core' from 'peerDependencies' and move 'lit' to 'devDependencies'#12189
sukvvon wants to merge 5 commits into
mainfrom
fix/lit-query-remove-query-core-peer

sukvvon commented Oct 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

nx-cloud Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

pkg-pr-new Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading

Review skipped

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

nx-cloud Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

pkg-pr-new Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026

size-limit report 📦

Uh oh!

coderabbitai Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 20, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Oct 20, 2026 •

edited

Loading

nx-cloud Bot commented Oct 20, 2026 •

edited

Loading

pkg-pr-new Bot commented Oct 20, 2026 •

edited

Loading

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading