Skip to content

Solid router v2 pre main sync#7517

Draft
brenelz wants to merge 238 commits into
solid-router-v2-prefrom
solid-router-v2-pre-main-sync
Draft

Solid router v2 pre main sync#7517
brenelz wants to merge 238 commits into
solid-router-v2-prefrom
solid-router-v2-pre-main-sync

Conversation

@brenelz
Copy link
Copy Markdown
Contributor

@brenelz brenelz commented May 31, 2026

No description provided.

tannerlinsley and others added 30 commits March 23, 2026 11:06
Put Start project setup in a single onboarding path for React and Solid while preserving old quick-start URLs with redirects.
Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
Co-authored-by: schiller-manuel <schiller-manuel@users.noreply.github.com>
Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
Co-authored-by: schiller-manuel <6340397+schiller-manuel@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com>
@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 31, 2026

View your CI Pipeline Execution ↗ for commit eb9f685

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 25m 51s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 16s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-31 03:07:40 UTC

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 31, 2026

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@brenelz brenelz marked this pull request as draft May 31, 2026 02:40
@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
High CVE: npm @vitejs/plugin-rsc has a Denial of Service Vulnerability in React Server Components

CVE: GHSA-w94c-4vhp-22gx @vitejs/plugin-rsc has a Denial of Service Vulnerability in React Server Components (HIGH)

Affected versions: < 0.5.26

Patched version: 0.5.26

From: e2e/react-start/rsc-deferred-hydration/package.jsonnpm/@vitejs/plugin-rsc@0.5.20

ℹ Read more on: This package | This alert | What is a CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@vitejs/plugin-rsc@0.5.20. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
High CVE: npm @vitejs/plugin-rsc has a Denial of Service with React Server Components

CVE: GHSA-v457-wxvj-p9w9 @vitejs/plugin-rsc has a Denial of Service with React Server Components (HIGH)

Affected versions: < 0.5.23

Patched version: 0.5.23

From: e2e/react-start/rsc-deferred-hydration/package.jsonnpm/@vitejs/plugin-rsc@0.5.20

ℹ Read more on: This package | This alert | What is a CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@vitejs/plugin-rsc@0.5.20. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
High CVE: Rollup 4 has Arbitrary File Write via Path Traversal

CVE: GHSA-mw96-cpmx-2vgc Rollup 4 has Arbitrary File Write via Path Traversal (HIGH)

Affected versions: < 2.80.0; >= 3.0.0 < 3.30.0; >= 4.0.0 < 4.59.0

Patched version: 4.59.0

From: pnpm-lock.yamlnpm/nitropack@2.13.1npm/nitro@3.0.1-alpha.2npm/vite-plugin-dts@4.2.3npm/@netlify/vite-plugin-tanstack-start@1.1.4npm/rollup@4.56.0

ℹ Read more on: This package | This alert | What is a CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/rollup@4.56.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Medium
Low adoption: npm ocache

Location: Package overview

From: pnpm-lock.yamlnpm/nitro-nightly@3.0.260522-betanpm/ocache@0.1.4

ℹ Read more on: This package | This alert | What are unpopular packages?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Unpopular packages may have less maintenance and contain other problems.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/ocache@0.1.4. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@github-actions
Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 15d7325d9d91
  • Measured at: 2026-05-31T02:42:54.986Z
  • Baseline source: history:9a6c12596ff6
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Initial gzip Raw Brotli Trend
react-router.minimal 87.25 KiB 0 B (0.00%) 87.12 KiB 273.94 KiB 75.84 KiB ███████▁▁▁▁
react-router.full 90.69 KiB 0 B (0.00%) 90.55 KiB 285.30 KiB 78.83 KiB ███████▁▁▁▁
solid-router.minimal 41.90 KiB +6.43 KiB (+18.13%) 41.78 KiB 122.46 KiB 37.86 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-router.full 46.46 KiB +6.29 KiB (+15.64%) 46.34 KiB 136.39 KiB 41.93 KiB ▁▁▁▁▁▁▁▁▁▁▁█
vue-router.minimal 52.97 KiB 0 B (0.00%) 52.84 KiB 150.26 KiB 47.66 KiB ███████▁▁▁▁
vue-router.full 58.60 KiB 0 B (0.00%) 58.47 KiB 167.99 KiB 52.51 KiB ███████▁▁▁▁
react-start.minimal 101.88 KiB 0 B (0.00%) 101.74 KiB 322.26 KiB 88.15 KiB ███████▁▁▁▁
react-start.deferred-hydration 102.61 KiB 0 B (0.00%) 101.76 KiB 323.63 KiB 88.82 KiB ███████▁▁▁▁
react-start.full 105.26 KiB 0 B (0.00%) 105.12 KiB 332.57 KiB 91.09 KiB ███████▁▁▁▁
react-start.rsbuild.minimal 99.58 KiB 0 B (0.00%) 99.41 KiB 316.74 KiB 85.74 KiB ███████▁▁▄▄
react-start.rsbuild.full 102.85 KiB 0 B (0.00%) 102.68 KiB 327.13 KiB 88.45 KiB ███████▁▁▄▄
solid-start.minimal 63.30 KiB +13.72 KiB (+27.67%) 63.17 KiB 191.49 KiB 56.00 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.deferred-hydration 66.62 KiB +13.78 KiB (+26.07%) 63.25 KiB 199.77 KiB 59.02 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.full 67.19 KiB +11.82 KiB (+21.34%) 67.06 KiB 202.98 KiB 59.29 KiB ▁▁▁▁▁▁▁▁▁▁▁█

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 31, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7517

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7517

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7517

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7517

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7517

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7517

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7517

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7517

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7517

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7517

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7517

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7517

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7517

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7517

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7517

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7517

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7517

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7517

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7517

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7517

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7517

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7517

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7517

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7517

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7517

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7517

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7517

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7517

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7517

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7517

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7517

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7517

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7517

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7517

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7517

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7517

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7517

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7517

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7517

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7517

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7517

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7517

commit: 4b80961

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 31, 2026

Merging this PR will improve performance by 3.09%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 2 untouched benchmarks
⏩ 1 skipped benchmark1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
ssr request loop (vue) 420.3 ms 454.6 ms -7.56%
ssr request loop (solid) 174.6 ms 161.6 ms +8.09%
client-side navigation loop (solid) 72.6 ms 66.2 ms +9.66%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing solid-router-v2-pre-main-sync (4b80961) with solid-router-v2-pre (67a9040)2

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

  2. No successful run was found on solid-router-v2-pre (5b9145d) during the generation of this report, so 67a9040 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment