Repository navigation
chore(skills): always offer an "all" option when picking comments - #2918
Merged
Merged
Conversation
🎩 PreviewA preview build has been created at: |
camielvs
force-pushed
the
chore/skills-select-all-comments
branch
from
October 21, 2026 16:36
8b024b9 to
69fd4dc
Compare
Collaborator
Author
|
✅ Manually smoke tested by @camielvs. |
camielvs
force-pushed
the
chore/skills-select-all-comments
branch
from
October 21, 2026 22:00
69fd4dc to
8403c88
Compare
maxy-shpfy
approved these changes
Oct 22, 2026
camielvs
force-pushed
the
chore/skills-select-all-comments
branch
3 times, most recently
from
October 22, 2026 19:59
aab0b75 to
1d9ec90
Compare
The review and address-pr-comments skills ask with a multi-select which findings to post or which comments to address. With many items, the 4-option cap forced grouping and there was no single way to pick everything. Both now put an "All findings" / "All comments" option first and say to group items rather than leave any out. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
camielvs
force-pushed
the
chore/skills-select-all-comments
branch
from
October 22, 2026 20:14
1d9ec90 to
13b9290
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
/reviewand/address-pr-commentsboth ask, through a multi-select, which items to act on: which findings to post, or which comments to address.AskUserQuestionallows at most 4 options per question and 4 questions. A large review therefore had to be split across several grouped questions, and there was no single choice for "all of them".Both skills now:
All findings (N)/All comments (N)first in the first question; selecting it covers every item, whatever else is selected;The gardening skill's E8 self-review reads only Step 1 of the review skill and skips the interactive steps, so it is unaffected.
Type of Change
Line Breakdown
Test Instructions
/review <PR>on a PR with several findings. The first option of the first question should beAll findings (N). Selecting only that option should post every finding./address-pr-commentson a branch with unresolved review comments. The first option should beAll comments (N).🤖 Generated with Claude Code