Repository navigation
Conversation
Four fixes to the add and replace form, carried over from the superseded workspace-secrets draft (#2886). They apply to Settings → Secrets today and to the team secrets screens that follow. - The value field sets `autocomplete="new-password"`, so browsers stop offering a saved login password for it. - A name containing `/` is refused. The name is a path segment in the replace and delete requests, so such a secret could be created but never changed or removed. - Deleting asks first. A deleted secret makes every run that uses it fail at launch, and once secrets are shared with a team that is everyone's runs. - Description and expiry fields, using the expiry picker from #2886. The backend only writes either when a value is sent, so neither can be cleared once set: replacing keeps the current description and expiry unless a new one is given, and the form says so. Expiry is not enforced by the backend, so the form calls it a reminder. The Settings list shows a secret's description under its name. The E2E `removeSecret` helper now confirms the delete dialog. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🎩 PreviewA preview build has been created at: |
camielvs
added this pull request to stack #2930
October 22, 2026 22:34
This was referenced Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Four fixes to the add and replace secret form. They apply to Settings → Secrets today, and to the team secrets screens later in this stack.
autocomplete="new-password", so browsers stop offering a saved login password for it./is refused. The name is a path segment in the replace and delete requests, so such a secret could be created but never changed or removed.The E2E
removeSecrethelper now confirms the delete dialog.Related Issue and Pull requests
Type of Change
Line Breakdown
Checklist
Screenshots (if applicable)
None yet.
Test Instructions
In Settings → Secrets:
/. The form refuses it.Additional Comments
None.
🤖 Generated with Claude Code