Repository navigation
Restore connection highlighting in runs - #2977
Merged
Mbeaulne merged 4 commits intoNov 2, 2026
Merged
Conversation
🎩 PreviewA preview build has been created at: |
camielvs
approved these changes
Nov 2, 2026
| <div | ||
| className={effect?.className} | ||
| style={ | ||
| effect?.opacity !== undefined ? { opacity: effect.opacity } : undefined |
Collaborator
There was a problem hiding this comment.
can this be part of classname via cn?
Collaborator
Author
There was a problem hiding this comment.
The opacity comes in as a number from the overlay settings (callers pass e.g. opacity: 0.3), so Tailwind can't turn it into a class at runtime. This is the same inline style the wrapper used in TaskNode.tsx before; I only moved it into a shared file. Switching to classes would mean changing the overlay settings to take something like className: "opacity-30". Happy to do that as a follow-up if you'd like.
Collaborator
Author
There was a problem hiding this comment.
that was an AI bot. I will clean it up now
Mbeaulne
enabled stacked auto-merge (squash)
November 2, 2026 21:55
Clicking handles in a run could leave edges faded after the highlight was cleared: the handle click replaced every edge with React Flow's display copy, overlay styles included, and the run canvas kept that as its edge state. The click now sends select changes, only for edges whose selection flips. Turning a highlight on or off also remounted the node card, because the effect wrapper rendered a bare child without an effect and a div with one. A collapsed task's expanded inputs closed again. The wrapper now always renders its div. On a collapsed task with hidden outputs, the outputs section toggled in the capture phase, so its output handles never got their own click. It now toggles on bubble, like the inputs section. Handles force pointer events only when they can't connect. On a connectable handle that override defeated React Flow's rule that lets a drag pass through handles it can't end on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Overlays now dim cards by passing a Tailwind class such as "opacity-30" through className, so the card wrapper no longer needs an inline style. Connections keep their numeric opacity, which is applied to the line's style. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
stacked auto-merge was automatically disabled
November 2, 2026 22:34
Pull Request is not mergeable
Mbeaulne
force-pushed
the
MB/run-connection-highlighting
branch
from
November 2, 2026 22:49
7ea11a6 to
7ed23fb
Compare
Mbeaulne
enabled stacked auto-merge (squash)
November 2, 2026 22:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Intent
Help people follow a connection to its source while inspecting a run.
Current behavior
In Run View v2, clicking a connection or a task handle leaves the connection gray. Pipeline input and output handles do not select their connections, and their cards do not show the editor’s connection highlight.
What changes
Clicking a connection or a connected task, input, or output handle highlights the connection and its endpoints in purple. Other connections fade, and clicking empty canvas clears the highlight. When zoomed out, each shared task handle highlights the connections for all ports on that side, including when an unconnected port overlaps a connected one. Run handles remain available for inspection without starting new connections; adding, reconnecting, and deleting connections remain disabled.
The change reuses the existing handle selection hook and the editor’s node highlight presentation. This PR is stacked on #2975.
How to test
Prerequisite: open Run View v2 for a run whose pipeline has a pipeline input connected to a task and a task output connected to a pipeline output.
Related Issue and Pull requests
Depends on #2975. Base:
MB/properties-title-spacing.Type of Change
Line Breakdown
Checklist
Screenshots (if applicable)
Connection and handle highlights were visually checked in a local browser preview.
Test Instructions
Actual verification at
7221999af:RemoteResourceInputand remote resource methods in unrelated files. No dependency or generated files were changed. CI typechecking passed with the locked dependencies on this commit.Additional Comments
Run editing restrictions are preserved. Staging verification has not been performed.