Skip to content

Enhance MainMenuDialog by adding descriptive text for button actions #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamrajeshk wants to merge 1 commit into
base: aviv-dev-latest
Choose a base branch
from
Open

Enhance MainMenuDialog by adding descriptive text for button actions #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions app/src/commonMain/kotlin/de/westnordost/streetcomplete/screens/main/MainMenuDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.layout.wrapContentSize
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.outlined.Cancel
import androidx.compose.material.icons.outlined.Download
Expand Down Expand Up @@ -94,7 +95,8 @@ fun MainMenuDialog(
contentDescription = null
)
},
text = stringResource(Res.string.action_download),
text = "Fetch map data",
description = "Fetch the latest quests from the server for this area"
)
HorizontalDivider(
modifier = Modifier
Expand Down Expand Up @@ -168,6 +170,7 @@ private fun CompactMenuButton(
icon: @Composable () -> Unit,
text: String,
modifier: Modifier = Modifier,
description: String = "",
enabled: Boolean = true,
colors: ButtonColors = ButtonDefaults.buttonColors(
containerColor = MaterialTheme.colorScheme.surface,
Expand All @@ -184,12 +187,22 @@ private fun CompactMenuButton(
verticalAlignment = Alignment.CenterVertically
) {
icon()
Text(
text = text,
modifier = Modifier.weight(1f).padding(horizontal = 16.dp),
textAlign = TextAlign.Start,
style = MaterialTheme.typography.bodyLarge,
)
Column {
Text(
text = text,
modifier = Modifier.padding(horizontal = 16.dp),
textAlign = TextAlign.Start,
style = MaterialTheme.typography.bodyLarge,
)
if (description.isNotEmpty()){
Text(
text = description,
modifier = Modifier.padding(horizontal = 16.dp),
textAlign = TextAlign.Start,
style = MaterialTheme.typography.bodySmall,
)
}
}
}
}
}
Expand Down