Skip to content

Update repository.py#28

Merged
susrisha merged 1 commit into
developfrom
feature-task-3953
Jul 3, 2026
Merged

Update repository.py#28
susrisha merged 1 commit into
developfrom
feature-task-3953

Conversation

@susrisha

@susrisha susrisha commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Added missing await

Updated TaskingProjectRepository.add_role so the auto-provisioning call now awaits and stores the result in provisioned_users instead of being invoked without capturing its return value. This ensures the async provisioning step completes before later logic uses its result.

Added missing await
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e106f882-de48-45d1-8ce6-3f4d33eed444

📥 Commits

Reviewing files that changed from the base of the PR and between d19d3c5 and f19fcb7.

📒 Files selected for processing (1)
  • api/src/tasking/projects/repository.py

📝 Walkthrough

Walkthrough

A single-line change in TaskingProjectRepository.add_role now captures the return value of _provision_users_from_tdei into a local variable provisioned_users, instead of discarding it as before.

Changes

Provisioning Return Value Capture

Layer / File(s) Summary
Assign provisioning result
api/src/tasking/projects/repository.py
add_role now assigns the result of _provision_users_from_tdei(...) to provisioned_users instead of ignoring it.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A tiny hop, a value saved,
No longer lost, no longer waved.
provisioned_users now holds tight,
One line of code, set just right. 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is too generic and only names a file, so it doesn't clearly describe the actual change. Use a concise title that states the main change, such as adding the missing await in repository.py.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@susrisha susrisha merged commit 09d1ed5 into develop Jul 3, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants