Align ARGS_NOEXCEPT completion behavior with throwing mode#174
Merged
Conversation
Owner
|
Makes sense to me. The nothrow code has had a lot of issues being consistent with the throw code. It's a fairly half-baked feature. Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an inconsistency between throwing mode and
ARGS_NOEXCEPTduring shell completion parsing.In throwing mode, recursive parsing of partial completion input suppresses ordinary parse failures and returns empty completion output.
ARGS_NOEXCEPTdid not mirror that behavior and could leakError::Parsestate for unknown commands during completion.Changes
Error::Completionstate after recursive completion parsing inARGS_NOEXCEPTResult
ARGS_NOEXCEPTcompletion behavior now matches the existing throwing-mode semantics for partial/unknown command completion input.