Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 5 additions & 0 deletions .github/instructions/best-practices.instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ applyTo: src/vs/**

- Don't use context keys as a source of truth for application logic (for example, by reading `IContextKeyService.getContextKeyValue()` and branching on the result). Read the state from its owning service or model instead. Context keys are intended for declarative enablement and visibility, such as when clauses, command preconditions, and menu contributions.

## Multi-Window DOM

- Always create workbench DOM elements in the main window JavaScript realm, including elements that will be rendered in an auxiliary window. Use helpers such as `dom.$` and `dom.h`, or use `mainWindow.document.createElement`. Do not use `targetWindow.document.createElement` or `element.ownerDocument.createElement`; auxiliary windows intentionally reject `createElement` so that checks such as `element instanceof HTMLElement` continue to work.
- This rule applies to DOM element creation, not to window-bound APIs. Resolve the target window with `dom.getWindow(element)` when using APIs such as timers, animation frames, focus, observers, or `getComputedStyle`.

## URI

- Don't hardcode URI scheme strings like `'file'`, `'untitled'`, or `'vscode-remote'`. Use the `Schemas` constants from `vs/base/common/network.ts` (e.g. `Schemas.file`, `Schemas.untitled`, `Schemas.vscodeRemote`).
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/chat-perf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ jobs:
name: build-output

- name: Restore Electron cache
uses: actions/cache/restore@caa296126883cff596d87d8935842f9db880ef25 # v5.1.0
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ~/.cache/electron
key: electron-${{ runner.os }}-${{ hashFiles('.nvmrc', 'package.json') }}
Expand All @@ -264,7 +264,7 @@ jobs:
run: node build/lib/preLaunch.ts

- name: Restore Playwright cache
uses: actions/cache/restore@caa296126883cff596d87d8935842f9db880ef25 # v5.1.0
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ~/.cache/ms-playwright
key: playwright-${{ runner.os }}-${{ hashFiles('package.json') }}
Expand Down Expand Up @@ -437,7 +437,7 @@ jobs:
name: build-output

- name: Restore Electron cache
uses: actions/cache/restore@caa296126883cff596d87d8935842f9db880ef25 # v5.1.0
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ~/.cache/electron
key: electron-${{ runner.os }}-${{ hashFiles('.nvmrc', 'package.json') }}
Expand All @@ -446,7 +446,7 @@ jobs:
run: node build/lib/preLaunch.ts

- name: Restore Playwright cache
uses: actions/cache/restore@caa296126883cff596d87d8935842f9db880ef25 # v5.1.0
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ~/.cache/ms-playwright
key: playwright-${{ runner.os }}-${{ hashFiles('package.json') }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/copilot-setup-steps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jobs:

- name: Restore built-in extensions cache
id: cache-builtin-extensions
uses: actions/cache/restore@caa296126883cff596d87d8935842f9db880ef25 # v5.1.0
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
enableCrossOsArchive: true
path: .build/builtInExtensions
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-darwin-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:

- name: Restore built-in extensions cache
id: cache-builtin-extensions
uses: actions/cache/restore@caa296126883cff596d87d8935842f9db880ef25 # v5.1.0
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
enableCrossOsArchive: true
path: .build/builtInExtensions
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-linux-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ jobs:

- name: Restore built-in extensions cache
id: cache-builtin-extensions
uses: actions/cache/restore@caa296126883cff596d87d8935842f9db880ef25 # v5.1.0
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
enableCrossOsArchive: true
path: .build/builtInExtensions
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-win32-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:

- name: Restore built-in extensions cache
id: cache-builtin-extensions
uses: actions/cache/restore@caa296126883cff596d87d8935842f9db880ef25 # v5.1.0
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
enableCrossOsArchive: true
path: .build/builtInExtensions
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:

- name: Restore built-in extensions cache
id: cache-builtin-extensions
uses: actions/cache/restore@caa296126883cff596d87d8935842f9db880ef25 # v5.1.0
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
enableCrossOsArchive: true
path: .build/builtInExtensions
Expand Down Expand Up @@ -284,7 +284,7 @@ jobs:
node-version-file: extensions/copilot/.nvmrc

- name: Setup Python
uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
with:
python-version: '3.12'
architecture: 'x64'
Expand Down Expand Up @@ -378,7 +378,7 @@ jobs:
node-version-file: extensions/copilot/.nvmrc

- name: Setup Python
uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 # v6.3.0
uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
with:
python-version: '3.12'
architecture: 'x64'
Expand Down
53 changes: 0 additions & 53 deletions .github/workflows/require-commit-trailer.yml

This file was deleted.

10 changes: 10 additions & 0 deletions build/azure-pipelines/copilot/test-integration-steps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,16 @@ parameters:
type: string # linux, darwin, win32

steps:
- script: git lfs install --local
condition: and(succeeded(), eq(variables['Build.Repository.Provider'], 'TfsGit'))
displayName: Initialize Git LFS for Azure Repos

- script: git --config-env=http.extraheader=GIT_AUTH_HEADER lfs pull --include="extensions/copilot/test/simulation/cache/**"
condition: and(succeeded(), eq(variables['Build.Repository.Provider'], 'TfsGit'))
displayName: Pull Copilot test cache from Azure Repos
env:
GIT_AUTH_HEADER: "AUTHORIZATION: bearer $(System.AccessToken)"

# Setup copilot test environment (tokens, env vars)
- task: AzureCLI@2
inputs:
Expand Down
Loading
Loading