Repository navigation
Conversation
ch-z-hc
marked this pull request as ready for review
October 14, 2026 08:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
fillandselectdispatch syntheticinputevents withbubbles: truebut the defaultcomposed: false. For a control inside a shadow root, listeners on its host or document never receive those events. In particular,fill("")clears the DOM value and reports success without notifying document-level input listeners; there is no subsequent native text-insertion event to compensate.Fix
Set
composed: trueon the existing input events in fill preparation, fill completion, and select completion. Leavechangeevents and the rest of the interaction flow unchanged.Reuse the existing real-Chrome harness for foreground/background shadow-input clearing and add a select regression that executes the actual CDP function against a connected shadow-root select. All three new regressions fail on the original product code and pass with the three-line fix.
Validation
document.hasFocus()setup assertion, before the affected fill operation. The new regressions pass. Unchanged main initially passed all 107 browser tests; a repeat has 106 passed, 1 failed at the same focus setup assertion. This establishes that main can also fail there, not the underlying cause or an entirely green opt-in suite.No assertions/timeouts were relaxed and no new skip conditions were added. Rust and the other opt-in browser suites were not run. Implemented and tested with Codex assistance; no independent human review is claimed.