Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the storage test helper fixture to create temporary files safely, replacing use of tempfile.mktemp() with NamedTemporaryFile while keeping the same Path-based interface for tests.
Changes:
- Replace
tempfile.mktemp()usage withNamedTemporaryFile(delete=False)to avoid insecure temp-path generation. - Adjust
mktempfixture logic to always create a real file (optionally pre-populated with provided content) and continue cleaning up created files after the test.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+30
to
+34
| with NamedTemporaryFile(mode="w", delete=False) as fh: | ||
| fh.write(content) | ||
| filepath = Path(fh.name) | ||
| else: | ||
| with NamedTemporaryFile(delete=False) as fh: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.