fix: remove deprecated function tempfile.mktemp#268
Merged
narasux merged 2 commits intoTencentBlueKing:masterfrom Apr 22, 2026
Merged
fix: remove deprecated function tempfile.mktemp#268narasux merged 2 commits intoTencentBlueKing:masterfrom
narasux merged 2 commits intoTencentBlueKing:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the blue-krill SDK test utilities to avoid insecure temp-file creation patterns and aligns the dev test stack with a newer pytest version.
Changes:
- Replace
tempfile.mktemp()usage in the storages test fixture withNamedTemporaryFile(..., delete=False)to generate temp paths/files. - Bump
pytestdev dependency to>=7,<8. - Regenerate
poetry.lockto reflect the updated dependency set.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
sdks/blue-krill/tests/storages/conftest.py |
Updates the mktemp fixture implementation to avoid tempfile.mktemp(). |
sdks/blue-krill/pyproject.toml |
Updates pytest version constraint for dev dependencies. |
sdks/blue-krill/poetry.lock |
Lockfile regeneration after dependency updates (now indicates Poetry 2.2.1). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
narasux
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.