Skip to content

fix: remove deprecated function tempfile.mktemp#268

Merged
narasux merged 2 commits intoTencentBlueKing:masterfrom
xiaoj655:loong-dev
Apr 22, 2026
Merged

fix: remove deprecated function tempfile.mktemp#268
narasux merged 2 commits intoTencentBlueKing:masterfrom
xiaoj655:loong-dev

Conversation

@xiaoj655
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 22, 2026 08:42
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the blue-krill SDK test utilities to avoid insecure temp-file creation patterns and aligns the dev test stack with a newer pytest version.

Changes:

  • Replace tempfile.mktemp() usage in the storages test fixture with NamedTemporaryFile(..., delete=False) to generate temp paths/files.
  • Bump pytest dev dependency to >=7,<8.
  • Regenerate poetry.lock to reflect the updated dependency set.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
sdks/blue-krill/tests/storages/conftest.py Updates the mktemp fixture implementation to avoid tempfile.mktemp().
sdks/blue-krill/pyproject.toml Updates pytest version constraint for dev dependencies.
sdks/blue-krill/poetry.lock Lockfile regeneration after dependency updates (now indicates Poetry 2.2.1).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sdks/blue-krill/tests/storages/conftest.py
@narasux narasux merged commit 171d0e5 into TencentBlueKing:master Apr 22, 2026
12 of 13 checks passed
@xiaoj655 xiaoj655 deleted the loong-dev branch April 22, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants