Skip to content

Make lane count optional and stop displaying it (PP-4506)#283

Open
dbernstein wants to merge 3 commits into
mainfrom
feature/PP-4506-lane-count-optional
Open

Make lane count optional and stop displaying it (PP-4506)#283
dbernstein wants to merge 3 commits into
mainfrom
feature/PP-4506-lane-count-optional

Conversation

@dbernstein

Copy link
Copy Markdown
Contributor

Description

The Palace Manager backend is removing lane-size maintenance (see ThePalaceProject/circulation#3424), so the admin GET .../lanes response no longer includes a per-lane count.

  • interfaces.ts: make LaneData.count optional (count?: number) for backward compatibility with older servers.
  • Lane.tsx: stop rendering the " (count)" suffix next to the lane name.

count was display-only — no logic depended on it — so this degrades gracefully and is safe to ship independently of the backend change.

Motivation and Context

JIRA: PP-4506

Companion to ThePalaceProject/circulation#3424, which removes the lane size/count from the backend.

How Has This Been Tested?

  • tsc type-check passes.
  • tests/jest/components/Lane.test.tsx passes (2/2); Prettier clean.

@claude

claude Bot commented Jun 18, 2026

Copy link
Copy Markdown

Claude finished @dbernstein's task in 1m 34s —— View job


Code Review: Make lane count optional and stop displaying it (PP-4506)

  • Gather context (read diff, files, and surrounding tests)
  • Understand the request (detailed code review)
  • Verify no remaining count reads or display assertions
  • Post review

Summary

This is a clean, well-scoped change. The display-only " (count)" suffix is removed from Lane.tsx, LaneData.count is made optional with a clear deprecation comment explaining the backward-compat rationale, and the now-obsolete count assertions are dropped from the two affected tests. I confirmed there are no remaining reads of lane.count anywhere in src/ and no surviving (count) display assertions in either the mocha or jest test suites, so the removal is complete and degrades gracefully against both old and new backends. The remaining count: values in the test mock data are harmless (now-optional) and arguably useful for exercising the older-server path, so no change is needed there. No bugs or actionable issues found — looks good to merge.
· feature/PP-4506-lane-count-optional

@dbernstein dbernstein marked this pull request as draft June 18, 2026 22:16
@dbernstein dbernstein marked this pull request as ready for review June 19, 2026 19:08
The Palace Manager backend no longer returns a lane `count` field — lane
size maintenance was removed there. Mark `LaneData.count` optional (for
backward compatibility with older servers) and stop rendering the
"(count)" suffix next to the lane name in the Lane component.
The "(count)" suffix is no longer rendered (lane count was removed), so the
"drags a top-level lane" test no longer asserts it — it still verifies the
post-drag lane order via the lane names.
@dbernstein dbernstein force-pushed the feature/PP-4506-lane-count-optional branch from ea52344 to f5b64c9 Compare June 22, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant