Make lane count optional and stop displaying it (PP-4506)#283
Make lane count optional and stop displaying it (PP-4506)#283dbernstein wants to merge 3 commits into
Conversation
|
Claude finished @dbernstein's task in 1m 34s —— View job Code Review: Make lane count optional and stop displaying it (PP-4506)
SummaryThis is a clean, well-scoped change. The display-only |
The Palace Manager backend no longer returns a lane `count` field — lane size maintenance was removed there. Mark `LaneData.count` optional (for backward compatibility with older servers) and stop rendering the "(count)" suffix next to the lane name in the Lane component.
The "(count)" suffix is no longer rendered (lane count was removed), so the "drags a top-level lane" test no longer asserts it — it still verifies the post-drag lane order via the lane names.
ea52344 to
f5b64c9
Compare
Description
The Palace Manager backend is removing lane-size maintenance (see ThePalaceProject/circulation#3424), so the admin
GET .../lanesresponse no longer includes a per-lanecount.interfaces.ts: makeLaneData.countoptional (count?: number) for backward compatibility with older servers.Lane.tsx: stop rendering the" (count)"suffix next to the lane name.countwas display-only — no logic depended on it — so this degrades gracefully and is safe to ship independently of the backend change.Motivation and Context
JIRA: PP-4506
Companion to ThePalaceProject/circulation#3424, which removes the lane
size/countfrom the backend.How Has This Been Tested?
tsctype-check passes.tests/jest/components/Lane.test.tsxpasses (2/2); Prettier clean.