Skip to content

Commit 3491a0b

Browse files
Dan Carpentergregkh
authored andcommitted
cpufreq: s3c2416: double free on driver init error path
commit a69261e4470d680185a15f748d9cdafb37c57a33 upstream. The "goto err_armclk;" error path already does a clk_put(s3c_freq->hclk); so this is a double free. Fixes: 34ee550 ([CPUFREQ] Add S3C2416/S3C2450 cpufreq driver) Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent aad7041 commit 3491a0b

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/cpufreq/s3c2416-cpufreq.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,6 @@ static int s3c2416_cpufreq_driver_init(struct cpufreq_policy *policy)
400400
rate = clk_get_rate(s3c_freq->hclk);
401401
if (rate < 133 * 1000 * 1000) {
402402
pr_err("cpufreq: HCLK not at 133MHz\n");
403-
clk_put(s3c_freq->hclk);
404403
ret = -EINVAL;
405404
goto err_armclk;
406405
}

0 commit comments

Comments
 (0)