Skip to content

Commit a8686c9

Browse files
tititiou36gregkh
authored andcommitted
vb2: Fix an off by one error in 'vb2_plane_vaddr'
commit 5ebb6dd36c9f5fb37b1077b393c254d70a14cb46 upstream. We should ensure that 'plane_no' is '< vb->num_planes' as done in 'vb2_plane_cookie' just a few lines below. Fixes: e23ccc0 ("[media] v4l: add videobuf2 Video for Linux 2 driver framework") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent fa90f02 commit a8686c9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/media/v4l2-core/videobuf2-core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,7 @@ EXPORT_SYMBOL_GPL(vb2_core_create_bufs);
793793
*/
794794
void *vb2_plane_vaddr(struct vb2_buffer *vb, unsigned int plane_no)
795795
{
796-
if (plane_no > vb->num_planes || !vb->planes[plane_no].mem_priv)
796+
if (plane_no >= vb->num_planes || !vb->planes[plane_no].mem_priv)
797797
return NULL;
798798

799799
return call_ptr_memop(vb, vaddr, vb->planes[plane_no].mem_priv);

0 commit comments

Comments
 (0)