Skip to content

issue fixed successfully - #1052

Open
Abdullahi700 wants to merge 2 commits into
Traqora:mainfrom
Abdullahi700:done
Open

Abdullahi700 wants to merge 2 commits into
Traqora:mainfrom
Abdullahi700:done

Conversation

@Abdullahi700

@Abdullahi700 Abdullahi700 commented Oct 16, 2026 •

Copy link
Copy Markdown

Closes #892
Closes #896
Closes #895
Closes #891

Issue Summary

  • [testing] MLflow offline fallback #896 MLflow offline fallback: Startup exceptions now disable tracking cleanly, and logging becomes a no-op. ORM imports are deferred until registry methods need them. Added an offline-server regression test in test_mlflow_hooks.py.
  • [testing] Canary auto-rollback test #892 Canary auto-rollback: Fixed import ordering that blocked deployment tests. The existing tests verify rollback after an error-budget breach and confirm traffic returns to stable.
  • [testing] Artifact checksum verify #895 Artifact checksum verification: Added a tampering regression test in test_model_store.py. Fixed ModelStore.save_model metadata inputs that referenced undefined variables.
  • [testing] Blue-green split test #891 Blue-green split: Added a test in test_deployment_strategies_mock_services.py proving traffic switches to green only after a healthy check and deployment switch.

Supporting Changes

  • Made deployment and tracking package exports lazy so importing the tested modules doesn’t load unrelated modules with existing syntax errors: deployment package, tracking package.
  • Corrected import ordering and the malformed constructor annotation in the relevant storage and deployment modules, including artifact_store.py, data_versioning.py, artifact_metadata.py, blue_green.py, canary.py, and rollback_manager.py.

Verification: 46 focused tests passed. Ruff was unavailable. The suite required --noconftest because the shared test fixture hits an unrelated syntax error in blockchain_context.py; the MLflow test emitted one SQLAlchemy deprecation warning.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

📏 Pull request size

This pull request is within the review-friendly size limits. ✅

@drips-wave

drips-wave Bot commented Oct 16, 2026

Copy link
Copy Markdown

@Abdullahi700 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Abdullahi700

Copy link
Copy Markdown
Author

@oladeeayo @Hahfyeex @Oluwatomilola ..... Please review and merge this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[testing] MLflow offline fallback [testing] Artifact checksum verify [testing] Canary auto-rollback test [testing] Blue-green split test

1 participant