fix: remove accidental itar_experiments logger import#1
Open
LemonPi wants to merge 1 commit into
Open
Conversation
base_experiments.util imported logger from itar_experiments.env.env, a circular dependency (itar_experiments and its successor rumi depend on base_experiments). Use a local logger so base_experiments imports in a fresh env without itar_experiments. Accidental auto-import from 5549ae4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base_experiments/util.pyimportedloggerfromitar_experiments.env.env, creating a circular dependency:itar_experiments(and its successorrumi) depend heavily onbase_experiments, whilebase_experimentsreached back intoitar_experimentssolely to grab a module-level logger.git blameshows this was an accidental auto-import introduced in5549ae4 "Evaluate action error".Change
(
loggingis already imported.)This lets
base_experimentsbe imported in a fresh environment withoutitar_experimentspresent — required for therumilibrary packaging, which replacesitar_experiments.🤖 Generated with Claude Code