Skip to content

fix: remove accidental itar_experiments logger import#1

Open
LemonPi wants to merge 1 commit into
masterfrom
fix/remove-itar-logger-circular-import
Open

fix: remove accidental itar_experiments logger import#1
LemonPi wants to merge 1 commit into
masterfrom
fix/remove-itar-logger-circular-import

Conversation

@LemonPi
Copy link
Copy Markdown
Member

@LemonPi LemonPi commented May 30, 2026

Summary

base_experiments/util.py imported logger from itar_experiments.env.env, creating a circular dependency: itar_experiments (and its successor rumi) depend heavily on base_experiments, while base_experiments reached back into itar_experiments solely to grab a module-level logger. git blame shows this was an accidental auto-import introduced in 5549ae4 "Evaluate action error".

Change

-from itar_experiments.env.env import logger
+logger = logging.getLogger(__name__)

(logging is already imported.)

This lets base_experiments be imported in a fresh environment without itar_experiments present — required for the rumi library packaging, which replaces itar_experiments.

🤖 Generated with Claude Code

base_experiments.util imported logger from itar_experiments.env.env, a circular dependency (itar_experiments and its successor rumi depend on base_experiments). Use a local logger so base_experiments imports in a fresh env without itar_experiments. Accidental auto-import from 5549ae4.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant