Skip to content

chore: update http skill for vendor docs registry (#ENGCE-58964)#1607

Open
mrstark14 wants to merge 1 commit into
mainfrom
fix/http-fallback
Open

chore: update http skill for vendor docs registry (#ENGCE-58964)#1607
mrstark14 wants to merge 1 commit into
mainfrom
fix/http-fallback

Conversation

@mrstark14

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Claude finished @mrstark14's task in 2m 24s —— View job


PR Review: chore: update http skill for vendor docs registry (#ENGCE-58964)

  • Gather context — read review criteria, project conventions, and PR diff
  • Read full changed files for surrounding context
  • Check skill-specific rules (links, cross-references, secrets)
  • Post review findings

Summary

Adds a vendor-docs-registry.json to uipath-platform/references/integration-service/ mapping five vendors (Slack, Salesforce, Jira, ServiceNow, Mailchimp) to their connector keys and authoritative API doc URLs. Updates http-request.md with a new "Step 0" grounding workflow and two new Critical Rules (5, 6). Updates impl-connector.md in the maestro-flow skill with a blockquote pointing agents to the new registry before configuring HTTP nodes.

Change-by-Change Review

1. skills/uipath-platform/references/integration-service/vendor-docs-registry.json (new file)

Severity: OK

Well-structured registry. _comment explains purpose. Each vendor entry has connectorKey, docsUrl, dynamic, and notes. The notes fields carry real operational detail (ServiceNow query-mangling warning, Mailchimp cascading fields). No secrets or personal paths.

One minor observation: the ServiceNow docsUrl contains a release-specific path segment (australia) that will need updating as ServiceNow ships newer versions — acceptable since the registry is explicitly meant to be maintained over time.

2. skills/uipath-platform/references/integration-service/http-request.md

Severity: Medium — two formatting issues

  • Line 47 — missing space before backtick: Slack``chat.postMessage`` renders without a space between "Slack" and the inline code. Should be Slack ``chat.postMessage``` (add a space). Same issue appears on line 41 but only in the rendered Step 0 body.
    Fix this →

  • Line 132 — Critical Rule 6 has no body text: 6. **(Connector mode) Pass endpoint paths verbatim.** ends with an empty trailing space — no explanation follows the bold header. Every other rule in this section has a description. Add a brief body (e.g., "Do not rewrite dotted method names as nested paths — see Step 0.") or merge into Rule 5.
    Fix this →

3. skills/uipath-maestro-flow/references/author/references/plugins/http/impl-connector.md

Severity: Medium — broken backtick formatting

  • Line 45 — double backtick breaks inline code: (Slack ``chat.postMessage)has two opening backticks and one closing backtick. Markdown will not render this correctly — the inline code span is malformed. Should be `` (Slackchat.postMessage`) `` (single backtick on each side).
    Fix this →

  • Lines 43-46 — reference pointer discipline (Low): The if-listed / if-not-listed branches and the "Pass the endpoint path verbatim" sentence partially restate the logic already explained in http-request.md Step 0. Per reference-pointer discipline, the blockquote is a bridge and should contain only the tie-in sentence + unique routing. The verbatim-path detail is duplicated — consider trimming to just the link and letting Step 0 handle the branching detail.

What's Missing

  • Critical Rule 6 body text — currently empty (see finding above).

Area Ratings

Area Status Notes
Frontmatter OK No frontmatter changes in this PR
E2E Tests OK No new skill; existing behavior modified with vendor grounding — no new CLI workflows requiring new test tasks
Skill Body OK SKILL.md not changed
References & Assets Issue Broken backtick formatting (2 files), empty rule body
Repo Hygiene OK CODEOWNERS already covers both paths; no secrets; changes scoped to the two relevant skills

Issues for Manual Review

  • Verify that connectorKey values in vendor-docs-registry.json match the actual connector keys in UiPath IS (e.g., uipath-salesforce-slack for Slack, uipath-servicenow-servicenow for ServiceNow). Automated review cannot validate these against the live system.
  • Confirm the ServiceNow docsUrl (australia release) is the intended stable reference URL.

Conclusion

Solid addition — the vendor-docs-registry concept is well-designed and the grounding workflow in Step 0 addresses a real failure mode (wrong-but-plausible endpoints). Three formatting issues should be fixed before merge: the broken double-backtick in impl-connector.md:45, the missing space in http-request.md:47, and the empty Critical Rule 6 body in http-request.md:132. All are quick fixes.


@@ -0,0 +1,35 @@
{
"_comment": "Maps a vendor to its connector-key and the authoritative API docs URL used for baseline grounding. The live http-request call is the final authority. Add entries as new vendors are supported. 'dynamic' flags objects that can carry tenant-specific custom fields.",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extend the grounding to all 31 connectors

@mrstark14 mrstark14 force-pushed the fix/http-fallback branch 4 times, most recently from 76de2e3 to df076a1 Compare June 23, 2026 21:39
@mrstark14 mrstark14 force-pushed the fix/http-fallback branch from df076a1 to 367cecc Compare June 23, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants