feat(uipath-governance): path to green — operate tests, diagnose structure, description verbs#1651
Conversation
…green Add operate and diagnose verbs to SKILL.md description, a Troubleshoot subsection under "When to Use", diagnose reference navigation rows, and the full references/diagnose/ directory (CAPABILITY.md, failure-modes.md, troubleshooting-guide.md). Add 3 mode:operate smoke tests (deploy tenant, query deployed policy, evaluate access policy) and 2 mode:diagnose smoke tests (policy not applied, blocked invocation). Targets Build/Operate/ Diagnose scorecard improvement. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Claude finished @t-hsia's task in 3m 10s —— View job PR Review: feat(uipath-governance): path to green
SummaryAdds operate and diagnose coverage for the governance skill: 3 new operate smoke tests, 2 new diagnose smoke tests, a Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | 833 chars, under 1024 limit. Operate/Diagnose verbs added cleanly. |
| E2E Tests | OK | Pre-existing e2e tests cover build lifecycle. New tests are all smoke (correct for operate/diagnose command-shape validation). |
| Skill Body | OK | Troubleshoot section well-placed. Reference Navigation updated. |
| References & Assets | Issue | 6 broken relative links in failure-modes.md (../ should be ../../). |
| Repo Hygiene | OK | CODEOWNERS covers both /skills/uipath-governance/ and /tests/tasks/uipath-governance/. No secrets. Changes scoped to governance skill. |
Issues for Manual Review
- CLI command accuracy: The
deployment tenant configureverb (inaops_deploy_tenant_smoke.yaml) and the--tenant-name/--inputflags should be verified against the actual CLI. The reviewer should confirm these flags exist on the current@uipath/clirelease. access-policy evaluateflag names: Verify--resource-type,--resource-id,--actor-process-type,--actor-process-idare the actual flag names (not--resourceTypeetc.).- Failure mode fix references: Lines 102 and 135 of
failure-modes.mdreferenceplugins/actor/impl.md,plugins/tags/planning.md, andplugins/selector/impl.md— these exist in the repo but the content should be verified to contain the referenced anchors (#deny-to-allow-flip, Robot intent section).
Conclusion
Solid path-to-green PR that follows established patterns well. One High issue blocks merge: the 6 broken relative links in failure-modes.md where ../ needs to be ../../. This is a straightforward fix (all instances are the same off-by-one in directory depth). Everything else — SKILL.md changes, CAPABILITY.md, troubleshooting guide, and all 5 test YAMLs — looks clean and well-structured.
Recommendation: Request changes — fix the broken links in failure-modes.md, then this is ready to merge.
|
Claude finished @t-hsia's task in 3m 42s —— View job Coder-eval task lint (advisory)5 task YAMLs changed; per-task verdicts: 0 Critical, 0 High, 1 Medium, 0 Low, 4 OK. Rubric: .claude/commands/lint-task.md. This check is advisory and never blocks merge. Evidence of passing run❌ High — PR body does not claim the changed tasks have been run and passed. The test plan section contains unchecked
Per-task lint
|
…prompt consistency in path-to-green PR - failure-modes.md: fix `template get "<TEMPLATE_ID>"` placeholder to `"<PRODUCT_NAME>"` matching the actual CLI positional argument - aops_deployed_policy_query_smoke: change lifecycle:setup to lifecycle:discover (querying deployed policy is read-only) - access_evaluate_smoke: change lifecycle:setup to lifecycle:discover (evaluate is a PDP query, not a mutation) - aops_diagnose_policy_not_applied_smoke: fix prompt saying "Studio policy" when the scenario uses product AITrustLayer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ID requirement Agent may not place the tenant GUID as a positional arg before the flags. Relax regex to check for `deployment tenant configure` with --input and --output json, without requiring exact GUID position. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
||
| **Symptom:** Admin deployed a policy to a tenant (or group), but a specific user still sees the old behavior or no policy at all. | ||
|
|
||
| **Causes:** |
There was a problem hiding this comment.
I would add scenario where user has multiple group policy and the one with lower priority wins instead of intended one.
There was a problem hiding this comment.
The solution is to lower (make it more important) the priority of the new policy.
| Compare the assignments at each level for the target product: | ||
| - If a user override exists (including explicit `null`), it wins over group and tenant. | ||
| - If a group override exists, it wins over tenant for members of that group. | ||
| - A `null` override means explicit "No Policy" — it is NOT the same as "no assignment" (which would inherit from the next level). |
There was a problem hiding this comment.
Similar to above, I would add above this line to also compare group policies priorities where lower priority wins.
| 1. Selector rule too broad — matches resources beyond the intended scope | ||
| 2. Actor rule excludes the calling user/group | ||
| 3. Executable rule blocks the actor process type | ||
| 4. Tags on the resource trigger a deny-intent policy |
There was a problem hiding this comment.
Nitpick: "Tags on the resource or executable trigger a deny-intent policy"
…back Addresses grant-tannert's review comments: - failure-modes.md: add cause #3 for multi-group scenario where lower priority number wins; update fix guidance - troubleshooting-guide.md: add group priority comparison step to precedence checking (Step 3) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
Addresses coverage gaps for Governance (uip gov) on the Coding Agents Scorecard, following the same pattern as the admin path-to-green (#1578).
Current scores: Build 50%, Operate 30%, Diagnose 15%
Changes
SKILL.md updates:
Operate:andDiagnose:verb phrases to description (856 chars, under 1024 limit)### Troubleshootsection in "When to Use" with 6 trigger patternsreferences/diagnose/directory (3 files, follows maestro-bpmn/admin pattern):CAPABILITY.md— structured capability index for diagnose mode (8 triggers, 6 rules, 8 common tasks)references/failure-modes.md— 6 named failure patterns: policy not taking effect, wrong policy applied, access policy too broad/narrow, deployed policy empty, policy create rejectedreferences/troubleshooting-guide.md— 5-step diagnostic priority ladderNew mode:operate smoke tests (3 files — previously zero!):
aops_deploy_tenant_smoke— deploy policy to tenantaops_deployed_policy_query_smoke— query effective deployed policyaccess_evaluate_smoke— evaluate access policy rulesNew mode:diagnose smoke tests (2 files):
aops_diagnose_policy_not_applied_smoke— investigate policy not taking effectaccess_diagnose_blocked_invocation_smoke— diagnose blocked tool invocationTest distribution after changes: 17 total — 5 build, 3 operate, 9 diagnose
Scorecard impact (expected)
Not in scope
uipCLI surface existsTest plan
uipath-governanceskill tag +mode:*taghooks/validate-skill-descriptions.shpasses🤖 Generated with Claude Code