fix: rewrite SDK field names in OData options for remaining services [PLT-106297]

[ninja-shreyash]

Summary

Extends PLT-102084 — applied to Jobs in #536 — to the remaining services whose field maps rename API fields on responses: Queues, Assets, Buckets, Processes, Attachments, Tasks.

Without this, a consumer who reads a renamed field on a response (e.g. processName, createdTime, folderId) and turns around to filter / orderby / select / expand by that same name is silently rejected by the API, which only knows the original field names (releaseName, creationTime, organizationUnitId, …).

Changes

Wire transformOptions(options, EntityMap) at every OData input edge that pairs with a response-side transformData(…, EntityMap):

Service	OData input edges wired
Queues	getAll, getById
Assets	getAll, getById, getByName (via shared helper)
Buckets	getFileMetaData, getFiles, getReadUri, _getWriteUri
Processes	getAll, getById, getByName, start (query options)
Attachments	getById
Tasks (action-center)	getAll, getById

FolderScopedService.getByNameLookup gains an optional requestFieldMap parameter so Assets/Processes can apply their respective maps inside the shared getByName flow before the OData $filter=Name eq '…' is built.

Test plan

• npm run typecheck — clean
• npm run lint — 0 warnings, 0 errors
• npm run test:unit — 1948 / 1948 passing (10 new tests)
• npm run build — produces dist/ output
• Per-service unit tests mirror the Jobs pattern from fix: rewrite SDK field names in OData filter/orderby/select/expand [PLT-102084] #536: assert the post-transformation shape on the call to PaginationHelpers.getAll / addPrefixToKeys. Tasks' suite identity-mocks the transform module, so its two new tests assert the wiring (that transformOptions is invoked with the right map) rather than the rewritten string.

Refs: PLT-106297, PLT-102084

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[claude]

Review summary

Three test-coverage gaps found. All three are actionable — the implementation itself looks correct.

New findings

1. tests/unit/services/orchestrator/buckets.test.ts line 1557 — PR wires transformOptions to four Bucket methods (getFileMetaData, getFiles, getReadUri, _getWriteUri) but only adds a transform-wiring test for getFiles. Per conventions, each sibling method needs its own test.

2. tests/unit/services/orchestrator/assets.test.ts line 275 — AssetService.getByName now passes AssetMap to getByNameLookup (new requestFieldMap path), but no test verifies that OData options like select are field-rewritten through that path.

3. tests/unit/services/orchestrator/processes.test.ts line 266 — same gap for ProcessService.getByName with ProcessMap (which has the most renames of any service here).

[claude]

Per the project convention: "when sibling methods share a configuration pattern, each method needs its own test for that pattern — verifying it on one method does not cover a sibling."

getAll, getById, and getByName all received tests that verify the transformOptions + addPrefixToKeys wiring. start uses the exact same pattern here for queryOptions, but no test exercises it. If this call were accidentally dropped, no unit test would catch it.

Add a test inside the start describe block:

it('should rewrite renamed SDK field names in query options before calling the API', async () => {
  const mockResponse = createMockProcessStartApiResponse([createMockProcessStartResponse()]);
  mockApiClient.post.mockResolvedValue(mockResponse);

  const request = PROCESS_TEST_CONSTANTS.PROCESS_START_REQUEST as ProcessStartRequest;
  await service.start(request, {
    folderId: TEST_CONSTANTS.FOLDER_ID,
    filter: "processName eq 'InvoiceBot'",
  });

  // processName → releaseName (ProcessMap reversed).
  expect(mockApiClient.post).toHaveBeenCalledWith(
    PROCESS_ENDPOINTS.START_PROCESS,
    expect.any(Object),
    expect.objectContaining({
      params: expect.objectContaining({
        '$filter': "releaseName eq 'InvoiceBot'",
      }),
    }),
  );
});

[claude]

Review summary

One new finding this run.

New finding

src/services/orchestrator/processes/processes.ts line 197 — start wires transformOptions(queryOptions, ProcessMap) for OData query options, the same pattern added to getAll, getById, and getByName. All three of those methods received a field-rewrite test in this PR, but start has none. Per conventions, each sibling method needs its own test for the shared pattern.